[Feature/Identity] AccessTokenManager stubs #4612
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
|
@peternied You may want to add |
peternied
changed the title
server/src/main/java/org/opensearch/identity/noop/NoopAuthenticationManager.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/identity/noop/NoopAuthenticationManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Nied <petern@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Peter Nied <petern@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
| * @opensearch.experimental | ||
| */ | ||
| public interface AuthenticationToken { | ||
|
|
There was a problem hiding this comment.
Should we comment, as a guideline, what formats should this support? or will that be taken into account once we finalize the implementation?
There was a problem hiding this comment.
I was loosely basing this on AuthenticationToken.java, but the aspect of having a principal I think we might want to consider before we jump into it
|
|
||
| @Override | ||
| public void expireAllTokens() { | ||
| // Tokens cannot be expired |
There was a problem hiding this comment.
Should we add one more line explaining "why"?
There was a problem hiding this comment.
NoopAccessTokenManager and all members of the Noop package does not allow for any auth failures/rejections of any kind (at least at this stage). We can certainly revisit as implementations start coming into place.
Description
AccessTokenManager stubs
Issues Resolved
[List any issues this PR will resolve]
Check List
New functionality includes testing.New functionality has been documented.New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.