Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple failing server tests. #453

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Fix multiple failing server tests. #453

merged 1 commit into from
Mar 23, 2021

Conversation

adnapibar
Copy link
Contributor

This commit fixes some renaming issues which as a result fixes multiple failing unit tests in the server module.

Issue #441

Signed-off-by: Rabi Panda adnapibar@gmail.com

@adnapibar adnapibar added >FORK Related to the fork process >test-failure Test failure from CI, local build, etc. Rename Renaming to OpenSearch labels Mar 23, 2021
@odfe-release-bot
Copy link

✅   DCO Check Passed 82e94f71671df45835cbe17c21dd5601f8b3e8d2

@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success 82e94f71671df45835cbe17c21dd5601f8b3e8d2

@odfe-release-bot
Copy link

✅   Gradle Precommit success 82e94f71671df45835cbe17c21dd5601f8b3e8d2

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good to me.
Thanks for the change!

Dropped a single comment.

This commit fixes the failing unit tests in the server module which started failing as a result of the renaming.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@odfe-release-bot
Copy link

✅   Gradle Wrapper Validation success dcbb8dd

@odfe-release-bot
Copy link

✅   DCO Check Passed dcbb8dd

@odfe-release-bot
Copy link

✅   Gradle Precommit success dcbb8dd

@adnapibar adnapibar mentioned this pull request Mar 23, 2021
77 tasks
@adnapibar adnapibar merged commit c79bab4 into opensearch-project:main Mar 23, 2021
@adnapibar adnapibar deleted the fix-server-tests branch March 23, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch >test-failure Test failure from CI, local build, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants