[Backport 2.0] Adding reta to codeowners #4475

opensearch-trigger-bot · 2022-09-09T22:23:52Z

Backport 8033183 from #2967

github-actions · 2022-09-09T22:25:07Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2938/
CommitID: 340d6d0

github-actions · 2022-09-09T22:28:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2939/
CommitID: 340d6d0

github-actions · 2022-09-09T22:54:26Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2940/
CommitID: 340d6d0

dreamer-89 · 2022-09-09T22:58:02Z

The gradle check fails during jdk 14 Adoptium installation. @peterzhuamazon @prudhvigodithi : Any ideas on how to fix this ?

java.io.IOException: Unable to locate release: jdk-14.0.2+12
	at io.jenkins.plugins.adoptopenjdk.AdoptOpenJDKInstaller.performInstallation(AdoptOpenJDKInstaller.java:109)
	at hudson.tools.InstallerTranslator.getToolHome(InstallerTranslator.java:70)
	at hudson.tools.ToolLocationNodeProperty.getToolHome(ToolLocationNodeProperty.java:108)
	at hudson.tools.ToolInstallation.translateFor(ToolInstallation.java:221)
	at hudson.model.JDK.forNode(JDK.java:149)
	at hudson.model.JDK.forNode(JDK.java:59)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:157)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:138)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
[Checks API] No suitable checks publisher found.
Finished: FAILURE

github-actions · 2022-09-10T01:16:45Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2943/
CommitID: 340d6d0

github-actions · 2022-09-12T18:02:23Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2974/
CommitID: 340d6d0

peterzhuamazon · 2022-09-12T20:00:03Z

The gradle check fails during jdk 14 Adoptium installation. @peterzhuamazon @prudhvigodithi : Any ideas on how to fix this ?

java.io.IOException: Unable to locate release: jdk-14.0.2+12
	at io.jenkins.plugins.adoptopenjdk.AdoptOpenJDKInstaller.performInstallation(AdoptOpenJDKInstaller.java:109)
	at hudson.tools.InstallerTranslator.getToolHome(InstallerTranslator.java:70)
	at hudson.tools.ToolLocationNodeProperty.getToolHome(ToolLocationNodeProperty.java:108)
	at hudson.tools.ToolInstallation.translateFor(ToolInstallation.java:221)
	at hudson.model.JDK.forNode(JDK.java:149)
	at hudson.model.JDK.forNode(JDK.java:59)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:157)
	at org.jenkinsci.plugins.workflow.steps.ToolStep$Execution.run(ToolStep.java:138)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
[Checks API] No suitable checks publisher found.
Finished: FAILURE

Fixed now, Jenkins removed the jdk14 support in auto install list, we manually add a zip now.

github-actions · 2022-09-12T20:17:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2976/
CommitID: 340d6d0

github-actions · 2022-09-12T22:00:55Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2988/
CommitID: 340d6d0

kartg · 2022-09-12T22:12:55Z

Unrelated failure:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:maintenance:buildBwcLinuxTar'.
> Building 1.3.5 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/maintenance/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.5-SNAPSHOT-linux-x64.tar.gz

The backport branch is up-to-date with the base branch i.e. 2.0 - diff

Will re-fire gradle check

github-actions · 2022-09-12T22:32:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2989/
CommitID: 340d6d0

dreamer-89 · 2022-09-12T22:47:59Z

@kartg: I think this is happening because of 1.3 bump from 1.3.5 to 1.3.6 on 1.3 branch. PR #4381 while 2.0 have 1.3.5 as latest. The last gradle check failed with same error as the last one

This is causing problems on all 2.x branches which run bwc on latest patch on previous major version.

dreamer-89 · 2022-09-12T22:53:18Z

@kartg: I think this is happening because of 1.3 bump from 1.3.5 to 1.3.6 on 1.3 branch. PR #4381 while 2.0 have 1.3.5 as latest.

This is causing problems on all 2.x branches which run bwc on latest patch on previous major version.

Raised #4491 to fix it.

kartg · 2022-09-12T23:24:13Z

Raised #4491 to fix it.

thanks @dreamer-89 !

dreamer-89 · 2022-09-12T23:28:25Z

Raised #4491 to fix it.

thanks @dreamer-89 !

The bwc change in #4491 is merged. Can you please rebase this PR

peterzhuamazon · 2022-09-12T23:46:17Z

Raised #4491 to fix it.

thanks @dreamer-89 !

The bwc change in #4491 is merged. Can you please rebase this PR

Rebased now.

Signed-off-by: Vacha Shah <vachshah@amazon.com> (cherry picked from commit 8033183)

codecov-commenter · 2022-09-13T00:10:42Z

Codecov Report

Merging #4475 (1587ef4) into 2.0 (1587ef4) will not change coverage.
The diff coverage is n/a.

❗ Current head 1587ef4 differs from pull request most recent head 6e3f3c5. Consider uploading reports for the commit 6e3f3c5 to get more accurate results

@@            Coverage Diff            @@
##                2.0    #4475   +/-   ##
=========================================
  Coverage     77.12%   77.12%           
  Complexity    62414    62414           
=========================================
  Files          4490     4490           
  Lines        271456   271456           
  Branches      40454    40454           
=========================================
  Hits         209371   209371           
  Misses        45565    45565           
  Partials      16520    16520

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2022-09-13T00:22:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2994/
CommitID: eab226c

dreamer-89 · 2022-09-13T00:27:17Z

Gradle check job 2994 is failing with below error. Flaky test failure!

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.IndicesRequestCacheIT.testQueryRewriteDatesWithNow" -Dtests.seed=BF4FF97173927D58 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=Egypt -Druntime.java=17

org.opensearch.indices.IndicesRequestCacheIT > testQueryRewriteDatesWithNow FAILED
    java.lang.AssertionError: 
    Expected: <8L>
         but: was <7L>
        at __randomizedtesting.SeedInfo.seed([BF4FF97173927D58:B4DF0D1C4C791B7]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.indices.IndicesRequestCacheIT.testQueryRewriteDatesWithNow(IndicesRequestCacheIT.java:390)

github-actions · 2022-09-13T00:34:55Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/2995/
CommitID: 6e3f3c5

dreamer-89 · 2022-09-13T00:36:29Z

Another test failure. As changes are not related to test area, refiring!

This flaky test is tracked in #4212

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections" -Dtests.seed=17E84502FA5C08FE -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ca -Dtests.timezone=Europe/Belgrade -Druntime.java=17

org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests > testReplicaThreadedUpdateToShardLimitsAndRejections FAILED
    java.lang.AssertionError: expected null, but was:<org.opensearch.index.stats.IndexingPressurePerShardStats@1921c06f>
        at __randomizedtesting.SeedInfo.seed([17E84502FA5C08FE:187071F3DADD266B]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotNull(Assert.java:756)
        at org.junit.Assert.assertNull(Assert.java:738)
        at org.junit.Assert.assertNull(Assert.java:748)
        at org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections(ShardIndexingPressureConcurrentExecutionTests.java:336)

github-actions · 2022-09-13T01:12:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/2996/
CommitID: 6e3f3c5

kartg · 2022-09-13T01:30:52Z

Thanks for persisting @dreamer-89 😎

I'll go ahead and merge this.

opensearch-trigger-bot bot requested a review from a team as a code owner September 9, 2022 22:23

kartg mentioned this pull request Sep 9, 2022

[Backport 2.0] Revert to Netty 4.1.79.Final #4440

Merged

6 tasks

CEHENKLE approved these changes Sep 9, 2022

View reviewed changes

dreamer-89 approved these changes Sep 9, 2022

View reviewed changes

dreamer-89 mentioned this pull request Sep 12, 2022

Add 1.3.6 bwc version to 2.0 branch #4491

Merged

6 tasks

Adding reta to codeowners (#2967)

6e3f3c5

Signed-off-by: Vacha Shah <vachshah@amazon.com> (cherry picked from commit 8033183)

VachaShah force-pushed the backport/backport-2967-to-2.0 branch from eab226c to 6e3f3c5 Compare September 12, 2022 23:59

kartg merged commit a9e883c into 2.0 Sep 13, 2022

kartg deleted the backport/backport-2967-to-2.0 branch September 13, 2022 01:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.0] Adding reta to codeowners #4475

[Backport 2.0] Adding reta to codeowners #4475

opensearch-trigger-bot bot commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

dreamer-89 commented Sep 9, 2022

github-actions bot commented Sep 10, 2022

github-actions bot commented Sep 12, 2022

peterzhuamazon commented Sep 12, 2022

github-actions bot commented Sep 12, 2022

github-actions bot commented Sep 12, 2022

kartg commented Sep 12, 2022

github-actions bot commented Sep 12, 2022

dreamer-89 commented Sep 12, 2022 •

edited

Loading

dreamer-89 commented Sep 12, 2022

kartg commented Sep 12, 2022

dreamer-89 commented Sep 12, 2022

peterzhuamazon commented Sep 12, 2022

codecov-commenter commented Sep 13, 2022

github-actions bot commented Sep 13, 2022

dreamer-89 commented Sep 13, 2022

github-actions bot commented Sep 13, 2022

dreamer-89 commented Sep 13, 2022 •

edited

Loading

github-actions bot commented Sep 13, 2022

kartg commented Sep 13, 2022

[Backport 2.0] Adding reta to codeowners #4475

[Backport 2.0] Adding reta to codeowners #4475

Conversation

opensearch-trigger-bot bot commented Sep 9, 2022

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

dreamer-89 commented Sep 9, 2022

github-actions bot commented Sep 10, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 12, 2022

Gradle Check (Jenkins) Run Completed with:

peterzhuamazon commented Sep 12, 2022

github-actions bot commented Sep 12, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 12, 2022

Gradle Check (Jenkins) Run Completed with:

kartg commented Sep 12, 2022

github-actions bot commented Sep 12, 2022

Gradle Check (Jenkins) Run Completed with:

dreamer-89 commented Sep 12, 2022 • edited Loading

dreamer-89 commented Sep 12, 2022

kartg commented Sep 12, 2022

dreamer-89 commented Sep 12, 2022

peterzhuamazon commented Sep 12, 2022

codecov-commenter commented Sep 13, 2022

Codecov Report

github-actions bot commented Sep 13, 2022

Gradle Check (Jenkins) Run Completed with:

dreamer-89 commented Sep 13, 2022

github-actions bot commented Sep 13, 2022

Gradle Check (Jenkins) Run Completed with:

dreamer-89 commented Sep 13, 2022 • edited Loading

github-actions bot commented Sep 13, 2022

Gradle Check (Jenkins) Run Completed with:

kartg commented Sep 13, 2022

dreamer-89 commented Sep 12, 2022 •

edited

Loading

dreamer-89 commented Sep 13, 2022 •

edited

Loading