Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace master terminology in documentation #4079

Conversation

xuezhou25
Copy link
Contributor

Description

Replace non-inclusive word "master" in *.md documentation file.

Issues Resolved

Close #2694

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@xuezhou25 xuezhou25 requested review from a team and reta as code owners August 2, 2022 00:50
Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing the non-inclusive term. 👍

@tlfeng tlfeng added documentation Improvements or additions to documentation v3.0.0 Issues and PRs related to version 3.0.0 labels Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@@ -319,13 +319,13 @@ Stashed values can be used in property names, eg:
- do:
cluster.state: {}

- set: { master_node: master }
- set: { cluster_manager_node: master }
Copy link
Member

@dreamer-89 dreamer-89 Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to replace master (value above) as well ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Changed it

Signed-off-by: Xue Zhou <xuezhou@amazon.com>
@xuezhou25 xuezhou25 force-pushed the Inclusive_naming_in_documentation branch from 1b4513f to cff7cfe Compare August 2, 2022 03:49
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@tlfeng
Copy link
Collaborator

tlfeng commented Aug 2, 2022

In build 1236:

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.search.DeletePitMultiNodeTests.testDeletePitWhileNodeDrop" -Dtests.seed=9E251EB37CB6899A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-HN -Dtests.timezone=Australia/Lord_Howe -Druntime.java=17

org.opensearch.search.DeletePitMultiNodeTests > testDeletePitWhileNodeDrop FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([9E251EB37CB6899A:6388D672E32212A0]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertFalse(Assert.java:65)
        at org.junit.Assert.assertFalse(Assert.java:75)
        at org.opensearch.search.DeletePitMultiNodeTests$1.onNodeStopped(DeletePitMultiNodeTests.java:184)
        at org.opensearch.test.InternalTestCluster$NodeAndClient.closeForRestart(InternalTestCluster.java:1028)
        at org.opensearch.test.InternalTestCluster.restartNode(InternalTestCluster.java:1931)
        at org.opensearch.test.InternalTestCluster.restartRandomDataNode(InternalTestCluster.java:1879)
        at org.opensearch.search.DeletePitMultiNodeTests.testDeletePitWhileNodeDrop(DeletePitMultiNodeTests.java:176)

It's not related to the code change in this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

@xuezhou25 xuezhou25 merged commit b0080eb into opensearch-project:main Aug 2, 2022
@xuezhou25 xuezhou25 deleted the Inclusive_naming_in_documentation branch August 2, 2022 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

Replace "master" terminology in documentation
3 participants