Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minio image version #3541

Merged

Conversation

lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented Jun 8, 2022

Signed-off-by: Lukáš Vlček lukas.vlcek@aiven.io

Description

Upgrading minio image to new version (the previous one was 3 years old).

On top of that addressing MinIO warning:

  • setup ulimits
  • use of static console port
  • do not use deprecated argument names

With regard to static port this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html

We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case).

A minor note: the third service in docker-compose was using a bit different indentation - fixing it.

Issues Resolved

Closes #3539

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lukas-vlcek lukas-vlcek requested review from a team and reta as code owners June 8, 2022 19:58
@reta reta added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Jun 8, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 72b9b8ec6bc85d5a961ad745cc6dee29144fa080
Log 5862

Reports 5862

@saratvemulapalli saratvemulapalli added >upgrade Label used when upgrading library dependencies (e.g., Lucene) dependencies Pull requests that update a dependency file v3.0.0 Issues and PRs related to version 3.0.0 v2.1.0 Issues and PRs related to version 2.1.0 labels Jun 8, 2022
@saratvemulapalli
Copy link
Member

@lukas-vlcek CI's are good. Are you good to merge this change?

@lukas-vlcek
Copy link
Contributor Author

@saratvemulapalli FYI: I will get back to this tomorrow.

On top of that addressing MinIO warning:
- setup ulimits
- use of static console port
- do not use deprecated argument names

With regard to static ports this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html

We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case).

Closes opensearch-project#3539

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@lukas-vlcek
Copy link
Contributor Author

lukas-vlcek commented Jun 27, 2022

I pushed an update. It is ready for review :-)

Still I am asking myself if it would be ok to switch to the LATEST image instead of fixed version. WDYT?
(The bottom line is that MinIO is doing new releases quite frequently, weekly is no exception ... which will bring the warning about outdated version back)

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 7a0cb04
Log 6370

Reports 6370

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. @saratvemulapalli want to have a final check and merge?

@Rishikesh1159 Rishikesh1159 added v2.2.0 and removed v2.1.0 Issues and PRs related to version 2.1.0 labels Jul 1, 2022
@saratvemulapalli saratvemulapalli removed backport 2.1 backport 2.0 Backport to 2.0 branch labels Jul 12, 2022
@saratvemulapalli
Copy link
Member

@reta I've dropped labels to backport to 2.0, 2.1 since they are already out.
Let me know if you think otherwise.

@saratvemulapalli saratvemulapalli merged commit 9af3407 into opensearch-project:main Jul 12, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2022
On top of that addressing MinIO warning:
- setup ulimits
- use of static console port
- do not use deprecated argument names

With regard to static ports this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html

We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case).

Closes #3539

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
(cherry picked from commit 9af3407)
reta pushed a commit that referenced this pull request Jul 13, 2022
On top of that addressing MinIO warning:
- setup ulimits
- use of static console port
- do not use deprecated argument names

With regard to static ports this is related to a change MinIO introduced in RELEASE.2021-07-08T01-15-01Z where the console was embedded into the server itself. For more details visit: https://docs.min.io/minio/baremetal/console/minio-console.html

We could let the port be assigned dynamically, however, when we set it statically it can give user an option to make use of the console web UI for MinIO troubleshooting (though I think the ports still need to be exported in this case).

Closes #3539

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
(cherry picked from commit 9af3407)

Co-authored-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@lukas-vlcek lukas-vlcek deleted the 3539_minio_upgrade branch July 22, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file >upgrade Label used when upgrading library dependencies (e.g., Lucene) v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Upgrade minio image to more recent version
7 participants