-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hppc from 0.8.1 to 0.9.1 in /server #3199
Bump hppc from 0.8.1 to 0.9.1 in /server #3199
Conversation
start gradle check |
start gradle check |
start gradle check |
1 similar comment
start gradle check |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
@dependabot recreate |
Bumps [hppc](https://github.com/carrotsearch/hppc) from 0.8.1 to 0.9.1. - [Release notes](https://github.com/carrotsearch/hppc/releases) - [Changelog](https://github.com/carrotsearch/hppc/blob/master/CHANGES.txt) - [Commits](carrotsearch/hppc@0.8.1...0.9.1) --- updated-dependencies: - dependency-name: com.carrotsearch:hppc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
836e5b3
to
47779a8
Compare
Signed-off-by: dependabot[bot] <support@github.com>
There are 3 changes in hppc that impact OpenSearch: - ObjectIntScatterMap has been removed. I could have replaced it with ObjectIntHashMap, but a plain java.util.HashMap seems to solve the problem well so I used that instead. - `indexRemove(int index)` is a new method in two interfaces that we extend in a delegate pattern, so I have had to add that method as a pass-through in two places. - The seeded version of `BitMixer.mix(int, int)` [has been removed][1]. The implementation that was removed simply xor'd the value to the seed before calling the single-int variant of the method. I have changed the OpenSearch code to do the xor directly, so this should be equivalent to the previous implementation. [1]: carrotsearch/hppc#10 Signed-off-by: Andrew Ross <andrross@amazon.com>
There are API changes in hppc that require code changes:
I have made these changes but |
This is the assertion that is failing in the upgrade tests: OpenSearch/server/src/main/java/org/opensearch/cluster/coordination/Coordinator.java Lines 1310 to 1323 in 40024fc
That code block compares cluster state by converting to JSON, then converting to a map and checking equality of the map. I do see hppc classes used in the |
hppc version 0.9.0 has breaking changes as mentioned in their release notes which are causing the failures - since this equality depends on the specific static ordering in the map, it is affected by the breaking change as mentioned in the release notes:
|
Will close this PR since it needs a manual code change and will create an issue to evaluate if we need this higher version of hppc and incorporate it in the code. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps hppc from 0.8.1 to 0.9.1.
Release notes
Sourced from hppc's releases.
... (truncated)
Changelog
Sourced from hppc's changelog.
... (truncated)
Commits
fdd0525
Prepare 0.9.1 release.72d0340
Apply spotless to headers.4b74f42
#26 Moved putIfAbsent to interface KTypeVTypeMap119f25f
Add github check action, update forbidden-apis.556d16a
Minor cleanups, plugin upgrades.634d35e
Update dependencies510dce6
GH-34: Optimize QuickSort inner loops.c34795b
Fix spotlessd882975
Add in-place QuickSort and use it in SortedIterationKTypeVTypeHashMap.415c176
Added SortedIterationKTypeVTypeHashMap: a sorted-iteration order view over an...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)