-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump HdrHistogram from 2.1.9 to 2.1.12 in /server #2135
Bump HdrHistogram from 2.1.9 to 2.1.12 in /server #2135
Conversation
Can one of the admins verify this patch? |
@dependabot recreate |
85dfe1d
to
30f3911
Compare
start gradle check |
The precommit on this PR needs to be fixed:
|
@dependabot recreate |
a360780
to
435de34
Compare
@saratvemulapalli Do we usually fix these by hand? |
|
start gradle check |
The first test failure looks from a flaky test but the other 3 look to be genuine since they are related to Hdr percentiles. I am not that aware of these tests and Hdr though. @saratvemulapalli Do you happen to know about it? |
Thats a good point. Looks like genuine failures. I do not know how it works but we can learn.
|
Sure. |
start gradle check |
This looks like a legit test failure. |
Yes this is not flaky test failure. From HdrHistogram version 2.1.10 and up there are some changes causing this.This test failure which was previously failing is not failing anymore:
There are still two tests failing, I will update here if I find any fix for these. |
@dependabot recreate |
start gradle check |
start gradle check |
One unnecessary exclusion:
The rest of the failures are hdr related:
|
Some more digging - even though there are 18 occurrences of
All of these failures are with the Filtered test test case - the rest of the cases ("Basic test", "only aggs test", etc.) pass. |
Looks like this change was introduced in |
Wrote up a test class to illustrate the change in behavior:
Test runs:
|
Side note: resolving the unnecessary exclusion of |
I pushed a commit the simply updates our tests to expect the new behavior of HdrHistogram. This seems like the right thing to do to me, but I'll want confirmation from some other folks as well. |
My change doesn't work because the backward compatibility tests run this test against a mixed cluster. In order to avoid problems there I think we'll have to change the test to work against both versions. |
There was a [change in behavior in HdrHistogram][1] that causes the tests to fail with the new version. The fix here is to add another value in the test data set for the failing test, which has the result of making both versions of HdrHistogram agree on the percentile values. [1]: HdrHistogram/HdrHistogram@5c7226c Signed-off-by: Andrew Ross <andrross@amazon.com>
e9b99bd
to
1948e5b
Compare
Signed-off-by: Andrew Ross <andrross@amazon.com>
Latest failures are:
None are reproducible. |
start gradle check |
* Bump HdrHistogram from 2.1.9 to 2.1.12 in /server Bumps [HdrHistogram](https://github.com/HdrHistogram/HdrHistogram) from 2.1.9 to 2.1.12. - [Release notes](https://github.com/HdrHistogram/HdrHistogram/releases) - [Commits](HdrHistogram/HdrHistogram@HdrHistogram-2.1.9...HdrHistogram-2.1.12) --- updated-dependencies: - dependency-name: org.hdrhistogram:HdrHistogram dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update test to match new behavior of HdrHistogram There was a [change in behavior in HdrHistogram][1] that causes the tests to fail with the new version. The fix here is to add another value in the test data set for the failing test, which has the result of making both versions of HdrHistogram agree on the percentile values. [1]: HdrHistogram/HdrHistogram@5c7226c Signed-off-by: Andrew Ross <andrross@amazon.com> * Remove unnecessary exclusion on third party audit Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit bce7f49)
* Bump HdrHistogram from 2.1.9 to 2.1.12 in /server Bumps [HdrHistogram](https://github.com/HdrHistogram/HdrHistogram) from 2.1.9 to 2.1.12. - [Release notes](https://github.com/HdrHistogram/HdrHistogram/releases) - [Commits](HdrHistogram/HdrHistogram@HdrHistogram-2.1.9...HdrHistogram-2.1.12) --- updated-dependencies: - dependency-name: org.hdrhistogram:HdrHistogram dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Update test to match new behavior of HdrHistogram There was a [change in behavior in HdrHistogram][1] that causes the tests to fail with the new version. The fix here is to add another value in the test data set for the failing test, which has the result of making both versions of HdrHistogram agree on the percentile values. [1]: HdrHistogram/HdrHistogram@5c7226c Signed-off-by: Andrew Ross <andrross@amazon.com> * Remove unnecessary exclusion on third party audit Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit bce7f49) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps HdrHistogram from 2.1.9 to 2.1.12.
Release notes
Sourced from HdrHistogram's releases.
Commits
2b35e19
Release 2.1.12af23c91
cleanup pomcd20906
Merge remote-tracking branch 'origin/master'deed2b8
packed array recorder updates31af170
Update maven.yml87373da
Changed comments for tooltips and change piechart to corechart. (#164)aff1d59
Minor spelling and grammar fixes. (#163)8ccc467
fix lgtm warningsfc67936
Fix lgtm warningsa4501f5
touchup commentsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)