Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Type parameter from TermVectors API #2104

Merged
merged 5 commits into from
Feb 15, 2022
Merged

[Remove] Type parameter from TermVectors API #2104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
766652d
[Remove] Type parameter from TermVectors API
nknize Feb 14, 2022
2222b38
fix test failures
nknize Feb 15, 2022
f996be6
fix more failing tests
nknize Feb 15, 2022
587248a
temporarily mute MoreLikeThisIT.testMoreLikeThisMalformedArtificialDocs
nknize Feb 15, 2022
6a23992
pr feedback changes
nknize Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
pr feedback changes 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
  • Loading branch information
@nknize
nknize committed Feb 15, 2022
commit 6a23992585dec1bb2cf9642efa986c0738ebb3cd
5 changes: 1 addition & 4 deletions server/src/main/java/org/opensearch/action/termvectors/MultiTermVectorsResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ public Failure(StreamInput in) throws IOException {
index = in.readString();
if (in.getVersion().before(Version.V_2_0_0)) {
// ignore removed type from pre-2.0.0 versions
String type = in.readOptionalString();
if (type != null) {
throw new IllegalStateException("types are no longer supported but found [" + type + "]");
}
in.readOptionalString();
}
id = in.readString();
cause = in.readException();
Expand Down
5 changes: 1 addition & 4 deletions server/src/main/java/org/opensearch/index/query/MoreLikeThisQueryBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,7 @@ public Item(@Nullable String index, XContentBuilder doc) {
index = in.readOptionalString();
if (in.getVersion().before(Version.V_2_0_0)) {
// types no longer supported so ignore
String type = in.readOptionalString();
if (type != null) {
throw new IllegalStateException("types are no longer supported but found [" + type + "]");
}
in.readOptionalString();
}
if (in.readBoolean()) {
doc = (BytesReference) in.readGenericValue();
Expand Down