delegate getMin/getMax methods for ExitableTerms#20775
Open
HUSTERGS wants to merge 1 commit intoopensearch-project:mainfrom
Open
delegate getMin/getMax methods for ExitableTerms#20775HUSTERGS wants to merge 1 commit intoopensearch-project:mainfrom
HUSTERGS wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit 2e85d39)Here are some key observations to aid the review process:
|
Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Contributor
|
Persistent review updated to latest commit 2e85d39 |
Contributor
|
❌ Gradle check result for 2e85d39: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ExitableTermsshould delegate getMin/getMax methods, or else thegetMax()fromOpenSearch/server/src/main/java/org/opensearch/search/sort/FieldSortBuilder.java
Lines 660 to 664 in 4ae7ff3
will call the default implementation, which is a slow path, and will get a flamegraph like below
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.