Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing invalid Java code example in JavaDoc #2008

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

lukas-vlcek
Copy link
Contributor

Description

Fixing invalid Java code example in JavaDoc

Including several other minor typos in JavaDoc.
No code has been changed, just JavaDoc.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lukáš Vlček lukas.vlcek@aiven.io

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lukas-vlcek lukas-vlcek force-pushed the JavaDoc_fix branch 3 times, most recently from f95584a to 93c92b2 Compare January 28, 2022 14:44
Including several other minor typos in JavaDoc.

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 0403614d2a0bea417f735b4bbff1daa6447046b9
Log 2116

Reports 2116

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f95584a54c38e35224bf6b22286fab16c80045e9
Log 2117

Reports 2117

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 93c92b29e6b7734e6004bdf56defee4c2a221f78
Log 2118

Reports 2118

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 53618db
Log 2119

Reports 2119

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

@tlfeng tlfeng added javadocs Anything related to javadocs v1.3.0 v2.0.0 Version 2.0.0 backport 1.x labels Jan 28, 2022
@saratvemulapalli saratvemulapalli merged commit a597d4d into opensearch-project:main Jan 31, 2022
@github-actions
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2008-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a597d4daac1caf0f62b1f3262893807014cea59f
# Push it to GitHub
git push --set-upstream origin backport/backport-2008-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2008-to-1.x.

@lukas-vlcek lukas-vlcek deleted the JavaDoc_fix branch February 2, 2022 13:54
@owaiskazi19 owaiskazi19 added the pending backport Identifies an issue or PR that still needs to be backported label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x javadocs Anything related to javadocs pending backport Identifies an issue or PR that still needs to be backported v1.3.0 v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants