Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Oct 27, 2025

Description

This is a small PR to make sure this setting can be used in opensearch.yml and not just on repo creation.

This was missed in #19220

Related Issues

See discussion around here: #18240 (comment)

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…y-s3 settings

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team as a code owner October 27, 2025 19:16
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for fc4970e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@owaiskazi19
Copy link
Member

@cwperks we can make this to 3.3.2

@cwperks
Copy link
Member Author

cwperks commented Oct 27, 2025

@peterzhuamazon Can we get this to 3.3.2?

@github-actions
Copy link
Contributor

❌ Gradle check result for 0786cff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 0786cff: SUCCESS

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.14%. Comparing base (753c135) to head (0786cff).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19788      +/-   ##
============================================
+ Coverage     73.10%   73.14%   +0.03%     
- Complexity    70959    70976      +17     
============================================
  Files          5737     5737              
  Lines        324766   324775       +9     
  Branches      46981    46982       +1     
============================================
+ Hits         237425   237558     +133     
+ Misses        68226    68108     -118     
+ Partials      19115    19109       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit 80141d5 into opensearch-project:main Oct 28, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants