Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Oct 24, 2025

Description

Bump ch.qos.logback modules from 1.5.18 to 1.5.20 in HDFS test fixture

This is to address CVEs flagged in 1.5.18. See https://mvnrepository.com/artifact/ch.qos.logback/logback-core

I also took the opportunity to replace instances of AccessController in this module to remove the removal warnings. Let me know if those should be taken out of this PR.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team as a code owner October 24, 2025 17:00
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 16c994a:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for 098fc69: SUCCESS

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.09%. Comparing base (753c135) to head (d632a52).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19763      +/-   ##
============================================
- Coverage     73.10%   73.09%   -0.02%     
+ Complexity    70959    70922      -37     
============================================
  Files          5737     5737              
  Lines        324766   324774       +8     
  Branches      46981    46982       +1     
============================================
- Hits         237425   237387      -38     
- Misses        68226    68265      +39     
- Partials      19115    19122       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions
Copy link
Contributor

❕ Gradle check result for d632a52: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@cwperks cwperks merged commit 789f136 into opensearch-project:main Oct 27, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants