Fixed a flaky test that is order dependent #19762
Open
+30
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
>test-failure
…uguoqingfz@gmail.com> Fixed a flaky test that is order dependent Signed-off-by: Joe Liu <liuguoqingfz@gmail.com> Signed-off-by: Joe Liu <guoqing4@illinois.edu>
liuguoqingfz
force-pushed
the
flakytest-19726
branch
from
c3707dc to
c964095
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19762 +/- ##
============================================
- Coverage 73.19% 73.17% -0.03%
+ Complexity 70946 70924 -22
============================================
Files 5735 5735
Lines 324654 324654
Branches 46962 46962
============================================
- Hits 237643 237556 -87
- Misses 67875 67906 +31
- Partials 19136 19192 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
reviewed
Oct 24, 2025
Comment on lines
+259
to
+275
| // Ensure test1 primaries are placed before adding other indices (prevents starvation) | ||
| assertBusy(() -> { | ||
| ClusterState s = client().admin().cluster().prepareState().get().getState(); | ||
| int primariesStarted = 0, unassigned = 0; | ||
| for (IndexRoutingTable irt : s.getRoutingTable()) { | ||
| if (irt.getIndex().getName().equals("test1")) { | ||
| for (IndexShardRoutingTable isrt : irt) { | ||
| for (ShardRouting sr : isrt) { | ||
| if (sr.primary() && sr.started()) primariesStarted++; | ||
| if (sr.unassigned()) unassigned++; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| assertEquals(3, primariesStarted); // 3 primaries started | ||
| assertEquals(3, unassigned); // 3 unassigned (the replicas) | ||
| }); |
There was a problem hiding this comment.
Can you replace this with a call to the ensureYellow("test1") helper method in the parent test class? The index should be red until all primaries are assigned, and will be yellow if replicas are unassigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allocation is concurrent and order-dependent. Sometimes test2/test3 fill up node capacity (the 6-shards-per-node cap) before all three test1 primaries get a slot. Then one test1 primary stays unassigned too, and you see 16 (or even 14) assigned instead of 17.
Related Issues
Resolves #19726
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.