Fix a flaky test that force caching #19761
Merged
+22
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
>test-failure
|
❌ Gradle check result for 105cff2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Joe Liu <guoqing4@illinois.edu>
liuguoqingfz
force-pushed
the
flakytest-19727
branch
from
105cff2 to
5257ed0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19761 +/- ##
============================================
- Coverage 73.19% 73.07% -0.13%
+ Complexity 70946 70862 -84
============================================
Files 5735 5735
Lines 324654 324654
Branches 46962 46962
============================================
- Hits 237643 237246 -397
- Misses 67875 68271 +396
- Partials 19136 19137 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
approved these changes
Oct 24, 2025
|
FYI @sgup432 I've already merged this but please do take a look in case you see any issue here. |
lawofcycles
pushed a commit
to lawofcycles/OpenSearch
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Joe Liu <guoqing4@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The request cache only caches cacheable requests. Need to explicitly set
.setRequestCache(true)on the search request to force caching. Without it, depending on defaults and the query/agg, the request might not be cached.Cache populated asynchronously / slight timing gap. Under test load, the stats read can race the cache put; need to retry/wait briefly.Related Issues
Resolves #19727
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.