Fix file-based ingestion flaky test #19757
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
>test-failure
varunbharadwaj
changed the title
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
varunbharadwaj
force-pushed
the
vb/filetest
branch
from
e53f9c5 to
101da07
Compare
|
❌ Gradle check result for 101da07: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 101da07: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19757 +/- ##
============================================
- Coverage 73.19% 73.03% -0.17%
+ Complexity 70946 70851 -95
============================================
Files 5735 5735
Lines 324654 324655 +1
Branches 46962 46962
============================================
- Hits 237643 237111 -532
- Misses 67875 68408 +533
Partials 19136 19136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
approved these changes
Oct 24, 2025
lawofcycles
pushed a commit
to lawofcycles/OpenSearch
that referenced
this pull request
Oct 24, 2025
…e file (opensearch-project#19757) Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
File-based ingestion is a test implementation, mainly for local testing.
FileBasedIngestionSingleNodeTests.testFileIngestionFromLatestPointerhas been marked a flaky test. The reason for this is the file-based consumer doesn't track the last read line if the start point is beyond the number of lines in the file. This results in reading the entire file in the next iteration, causing the flaky test.The flaky test could be reproduced locally with some changes, and this PR fixes this bug.
Related Issues
Resolves #19723
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.