Skip to content

Conversation

@Jinny-Wang
Copy link
Contributor

@Jinny-Wang Jinny-Wang commented Oct 23, 2025

Description

  • change loadHistoryUUID to protected,
  • change Origin#isFromTranslog to public
    so that subclasses of Engine implemented in plugin repository can access them

Related Issues

Resolves #19753

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@msfroh
Copy link
Contributor

msfroh commented Oct 23, 2025

@mch2 -- Any strong feelings on these APIs? You're the one who introduced loadHistoryUUID to share it between InternalEngine and NRTReplicationEngine. Any objections to making it protected so non-core Engine implementations can use it?

@github-actions
Copy link
Contributor

❌ Gradle check result for 3cc022a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mch2
Copy link
Member

mch2 commented Oct 24, 2025

@mch2 -- Any strong feelings on these APIs? You're the one who introduced loadHistoryUUID to share it between InternalEngine and NRTReplicationEngine. Any objections to making it protected so non-core Engine implementations can use it?

Nope no issue.

…og() to public

Signed-off-by: jinnyw <jinnyw@uber.com>
@Jinny-Wang Jinny-Wang force-pushed the publicize-methods-in-engine branch from 3cc022a to 91037c6 Compare October 28, 2025 18:34
@github-actions
Copy link
Contributor

✅ Gradle check result for 91037c6: SUCCESS

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.19%. Comparing base (8dd1286) to head (91037c6).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19752      +/-   ##
============================================
+ Coverage     73.12%   73.19%   +0.07%     
- Complexity    71099    71169      +70     
============================================
  Files          5754     5754              
  Lines        325296   325296              
  Branches      47052    47052              
============================================
+ Hits         237868   238115     +247     
+ Misses        68282    68024     -258     
- Partials      19146    19157      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msfroh msfroh merged commit 0c5ee15 into opensearch-project:main Oct 29, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request _No response_

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] make Engine loadHistoryUUID protected and Origin#isFromTranslog public

6 participants