- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.3k
[Engine] change loadHistoryUUID to protected, and Origin#isFromTransl… #19752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Engine] change loadHistoryUUID to protected, and Origin#isFromTransl… #19752
Conversation
41b3342    to
    3cc022a      
    Compare
  
    | @mch2 -- Any strong feelings on these APIs? You're the one who introduced  | 
| ❌ Gradle check result for 3cc022a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? | 
| 
 Nope no issue. | 
…og() to public Signed-off-by: jinnyw <jinnyw@uber.com>
3cc022a    to
    91037c6      
    Compare
  
    | Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@             Coverage Diff              @@
##               main   #19752      +/-   ##
============================================
+ Coverage     73.12%   73.19%   +0.07%     
- Complexity    71099    71169      +70     
============================================
  Files          5754     5754              
  Lines        325296   325296              
  Branches      47052    47052              
============================================
+ Hits         237868   238115     +247     
+ Misses        68282    68024     -258     
- Partials      19146    19157      +11     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
Description
so that subclasses of Engine implemented in plugin repository can access them
Related Issues
Resolves #19753
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.