Modernize FilePartitionConsumer.java #19736
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19736 +/- ##
============================================
- Coverage 73.14% 73.04% -0.11%
+ Complexity 70797 70796 -1
============================================
Files 5732 5732
Lines 324258 324258
Branches 46925 46925
============================================
- Hits 237186 236858 -328
- Misses 67897 68325 +428
+ Partials 19175 19075 -100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This does not work due to permission issues. We are checking for a different approach. |
Discussed w/ @varunbharadwaj and updated the README to explain how to explicitly grant permissions to a directory (using the same approach as Granting permission explicitly is a better/safer posture even for a plugin intended for tests/experiments. The fact that the older approach let you open files anywhere was a little sketchy. |
|
❌ Gradle check result for b55ffb7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b55ffb7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b55ffb7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Instead of using java.io.File, we can use java.nio.Path for a cleaner, more modern Java I/O experience. Signed-off-by: Michael Froh <msfroh@apache.org>
Signed-off-by: Michael Froh <msfroh@apache.org>
msfroh
force-pushed
the
use_nio_file_apis
branch
from
b55ffb7 to
22ded2f
Compare
|
❌ Gradle check result for 22ded2f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3 participants
Description
Instead of using java.io.File, we can use java.nio.Path for a cleaner, more modern Java I/O experience.
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.