Skip to content

Conversation

@kh3ra
Copy link
Contributor

@kh3ra kh3ra commented Oct 22, 2025

Description

Removing the experimental feature flag for merged segment warmer since its controlled by a dynamic cluster setting(added as part of PR) now. The feature is disabled by default.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kh3ra kh3ra changed the title Dev/remove merged segment warmer experimental flag Remove merged segment warmer experimental flag Oct 22, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for bc0c2b4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kh3ra kh3ra force-pushed the dev/remove-merged-segment-warmer-experimental-flag branch 2 times, most recently from dd4d5d1 to d8217bf Compare October 22, 2025 09:56
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashking94
Copy link
Member

@kh3ra can you please ensure that the java spotless checks are passing before you push these PRs?

@github-actions
Copy link
Contributor

❌ Gradle check result for d8217bf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419
Copy link
Member

Can you please also add a changelog?

@github-actions
Copy link
Contributor

❌ Gradle check result for caeff59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kh3ra kh3ra force-pushed the dev/remove-merged-segment-warmer-experimental-flag branch from caeff59 to 9286303 Compare October 24, 2025 09:41
@github-actions
Copy link
Contributor

❌ Gradle check result for 9286303: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kh3ra kh3ra force-pushed the dev/remove-merged-segment-warmer-experimental-flag branch 2 times, most recently from 5fe4928 to 7beb3e3 Compare October 24, 2025 10:05
@github-actions
Copy link
Contributor

❌ Gradle check result for 7beb3e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 6ddb75c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for dac0824: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kh3ra kh3ra force-pushed the dev/remove-merged-segment-warmer-experimental-flag branch from 59701a6 to 45110b8 Compare October 24, 2025 17:20
@github-actions
Copy link
Contributor

❌ Gradle check result for 45110b8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kh3ra
Copy link
Contributor Author

kh3ra commented Oct 24, 2025

flaky: #17154

Aditya Khera added 5 commits October 25, 2025 01:43
Signed-off-by: Aditya Khera <kheraadi@amazon.com>

# Conflicts:
#	server/src/main/java/org/opensearch/indices/recovery/RecoverySettings.java
#	server/src/test/java/org/opensearch/indices/recovery/RecoverySettingsDynamicUpdateTests.java
Added changelog
Fixed tests

Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
@kh3ra kh3ra force-pushed the dev/remove-merged-segment-warmer-experimental-flag branch from 45110b8 to ae996eb Compare October 24, 2025 20:13
@github-actions
Copy link
Contributor

✅ Gradle check result for ae996eb: SUCCESS

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.12%. Comparing base (f6b6115) to head (ae996eb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/opensearch/index/engine/InternalEngine.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19715      +/-   ##
============================================
+ Coverage     73.10%   73.12%   +0.02%     
- Complexity    70919    70939      +20     
============================================
  Files          5737     5737              
  Lines        324767   324759       -8     
  Branches      46982    46980       -2     
============================================
+ Hits         237430   237492      +62     
+ Misses        68201    68164      -37     
+ Partials      19136    19103      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kh3ra kh3ra changed the title Remove merged segment warmer experimental flag Remove FeatureFlag.MERGED_SEGMENT_WARMER_EXPERIMENTAL_FLAG Oct 25, 2025
@ashking94 ashking94 merged commit e52ebe4 into opensearch-project:main Oct 25, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants