-
Couldn't load subscription status.
- Fork 2.3k
Remove FeatureFlag.MERGED_SEGMENT_WARMER_EXPERIMENTAL_FLAG #19715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FeatureFlag.MERGED_SEGMENT_WARMER_EXPERIMENTAL_FLAG #19715
Conversation
|
❌ Gradle check result for bc0c2b4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dd4d5d1 to
d8217bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@kh3ra can you please ensure that the java spotless checks are passing before you push these PRs? |
|
❌ Gradle check result for d8217bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Can you please also add a changelog? |
2498b96 to
caeff59
Compare
|
❌ Gradle check result for caeff59: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
caeff59 to
9286303
Compare
|
❌ Gradle check result for 9286303: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5fe4928 to
7beb3e3
Compare
|
❌ Gradle check result for 7beb3e3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 6ddb75c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for dac0824: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
59701a6 to
45110b8
Compare
|
❌ Gradle check result for 45110b8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
flaky: #17154 |
Signed-off-by: Aditya Khera <kheraadi@amazon.com> # Conflicts: # server/src/main/java/org/opensearch/indices/recovery/RecoverySettings.java # server/src/test/java/org/opensearch/indices/recovery/RecoverySettingsDynamicUpdateTests.java
Added changelog Fixed tests Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
45110b8 to
ae996eb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19715 +/- ##
============================================
+ Coverage 73.10% 73.12% +0.02%
- Complexity 70919 70939 +20
============================================
Files 5737 5737
Lines 324767 324759 -8
Branches 46982 46980 -2
============================================
+ Hits 237430 237492 +62
+ Misses 68201 68164 -37
+ Partials 19136 19103 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Removing the experimental feature flag for merged segment warmer since its controlled by a dynamic cluster setting(added as part of PR) now. The feature is disabled by default.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.