Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook to execute custom logic before Integ test task starts #1969

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Jan 24, 2022

Description

Add hook to execute custom logic before the integ test starts.
This is required for a workaround to enable the jacoco code coverage for Integ Tests.
Related PR: opensearch-project/cross-cluster-replication#284

Issues Resolved

[1926]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala requested a review from a team as a code owner January 24, 2022 17:03
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 783779f
Log 2035

Reports 2035

@owaiskazi19
Copy link
Member

@ankitkala you need to commit/amend with -s for DCO check.

@shwetathareja
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 783779f
Log 2039

Reports 2039

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@shwetathareja
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5896c8e
Log 2040

Reports 2040

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5896c8e
Log 2041

Reports 2041

@shwetathareja shwetathareja merged commit 56ae7fa into opensearch-project:main Jan 25, 2022
github-actions bot pushed a commit that referenced this pull request Jan 25, 2022
Signed-off-by: Ankit Kala <ankikala@amazon.com>
(cherry picked from commit 56ae7fa)
nknize pushed a commit that referenced this pull request Jan 26, 2022
Add hook to execute custom logic before the integ test starts.
This is required for a workaround to enable the jacoco code coverage for Integ Tests.

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants