Fix IndexOutOfBoundsException when running include/exclude with non-existent prefix term #19637
Conversation
harshavamsi
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
@msfroh could you take a look since you added this optimization |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
fix-prefix-ordinals-index-out-of-bounds
branch
from
e90ffb1 to
7f1e867
Compare
|
❌ Gradle check result for 7f1e867: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19637 +/- ##
============================================
+ Coverage 73.12% 73.15% +0.02%
+ Complexity 70973 70941 -32
============================================
Files 5737 5737
Lines 324767 324769 +2
Branches 46982 46983 +1
============================================
+ Hits 237483 237581 +98
+ Misses 68151 67968 -183
- Partials 19133 19220 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Since this feature was released in 3.0.0, should backport to 3.1, 3.2, 3.3? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
|
|
|
❌ Gradle check result for e160c63: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
|
❌ Gradle check result for cd5b6e7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
github-project-automation
bot
moved this from In-Review
to In Progress
in Performance Roadmap
4 participants
Description
As described in #19636, we check the bounds of the ordinal before we seek
Related Issues
Resolves #19636
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.