-
Couldn't load subscription status.
- Fork 2.3k
[RemoteStore]: Add support for repository with Server side encryption enabled and client side encryption as well based on a flag. #19630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RemoteStore]: Add support for repository with Server side encryption enabled and client side encryption as well based on a flag. #19630
Conversation
c6051f6 to
01b6ca2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19630 +/- ##
============================================
+ Coverage 73.12% 73.15% +0.02%
- Complexity 70973 70974 +1
============================================
Files 5737 5738 +1
Lines 324767 324878 +111
Branches 46982 47001 +19
============================================
+ Hits 237483 237649 +166
+ Misses 68151 68091 -60
- Partials 19133 19138 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❕ Gradle check result for 3560a0a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreProviderFactory.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
...java/org/opensearch/repositories/blobstore/ServerSideEncryptionEnabledBlobStoreProvider.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/MetadataCreateIndexService.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for cca7474: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
c24efed to
65e2eac
Compare
|
❌ Gradle check result for 65e2eac: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
|
❌ Gradle check result for 845b16a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
Testing details |
|
❌ Gradle check result for 24c87db: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 24c87db: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Pranit Kumar <pranikum@amazon.com>
|
❌ Gradle check result for 95bdef6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 95bdef6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
We will be adding support of having S3 repository to support both client side and server side encryption enabled blobs. Currently BlobStoreRepository only supports Single BlobStore created Lazily and once created the repository is tied to that BlobStore.
With this change we will be moving away from that design. We will be adding BlobStoreProvider which will be responsible for creating client side encrypted and server side encrypted BlobStore. Any Repository which needs this support can leverage by overriding appropriate builder methods.
Related Issues
[Resolves #19235]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.