Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Rename files under "qa" folder #194

Merged
merged 3 commits into from
Mar 4, 2021
Merged

[Rename] Rename files under "qa" folder #194

merged 3 commits into from
Mar 4, 2021

Conversation

harold-wang
Copy link
Contributor

@harold-wang harold-wang commented Mar 4, 2021

Issue #160, if available:

Description of changes:

Rename files under "qa" folder:

  1. Rename Elasticsearch* class to Opensearch*
  2. Rename elasticsearch* instance to opensearch*
  3. Rename package org.elasticsearch.* to org.opensearch.*
  4. Rename import org.elasticsearch.* to org.opensearch.*

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Harold Wang <harowang@amazon.com>
@harold-wang harold-wang self-assigned this Mar 4, 2021
@harold-wang harold-wang added Rename Renaming to OpenSearch >FORK Related to the fork process labels Mar 4, 2021
@harold-wang harold-wang changed the base branch from main to rename/opensearch March 4, 2021 00:43
@odfe-release-bot
Copy link

Request for Admin to accept this test.

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments but otherwise LGTM.

@@ -36,7 +36,7 @@
private static final String OS_NAME = System.getProperty("os.name");
private static final boolean WINDOWS = OS_NAME.startsWith("Windows");

// These match the values defined in org.elasticsearch.gradle.testclusters.ElasticsearchNode
// These match the values defined in org.opensearch.gradle.testclusters.OpensearchNode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'S' in OpenSearch should be capital OpenSearchNode

Copy link
Contributor Author

@harold-wang harold-wang Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nknize it was ElasticsearchNode, I think we should use "OpensearchNode" instead of "OpenSearchNode". I will merge, will keep a note to check if I see "org.elasticsearch.gradle.testclusters.OpenSearchNode" after all renaming is done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nknize I changed OpensearchNode to OpenSearchNode in PR #212, thanks

@@ -17,47 +17,47 @@
* under the License.
*/

package org.elasticsearch.search;
package org.opensearch.search;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file directory doesn't match with package name, please rename those.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put all the git mv to different PR. thanks

@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.elasticsearch.common.logging;
package org.opensearch.common.logging;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name doesn't match with package name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put all the git mv to different PR. thanks as I mentioned #194 (comment)

@@ -17,34 +17,34 @@
* under the License.
*/

package org.elasticsearch.upgrades;
package org.opensearch.upgrades;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name doesn't match with package name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put all the git mv to different PR. thanks as I mentioned in #194 (comment)

@@ -17,10 +17,10 @@
* under the License.
*/

package org.elasticsearch.bootstrap;
package org.opensearch.bootstrap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • file directory doesn't match with package name.
  • file name needs to be changed to OpenSearchPolicyUnitTests.java

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put all the git mv to different PR as I mentioned #194 (comment)

@@ -17,13 +17,13 @@
* under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name needs to be changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put all the git mv to different PR as I mentioned in #194 (comment)

@@ -16,11 +16,11 @@
* specific language governing permissions and limitations
* under the License.
*/
package org.elasticsearch.upgrades;
package org.opensearch.upgrades;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name doesn't match with package name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file or dir rename is taken care of in another PR.

@@ -17,46 +17,46 @@
* under the License.
*/

package org.elasticsearch.http;
package org.opensearch.http;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name doesn't match with package name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file or dir rename is taken care of in another PR.

@@ -17,11 +17,11 @@
* under the License.
*/

package org.elasticsearch.smoketest;
package org.opensearch.smoketest;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name doesn't match with package name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file or dir rename is taken care of in another PR.

@@ -17,13 +17,13 @@
* under the License.
*/

package org.elasticsearch.smoketest;
package org.opensearch.smoketest;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name doesn't match with package name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file or dir rename is taken care of in another PR.

import org.elasticsearch.script.TemplateScript;
import org.elasticsearch.script.mustache.MustacheScriptEngine;
import org.elasticsearch.test.ESTestCase;
package org.opensearch.ingest;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory name doesn't match with package name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file or dir rename is taken care of in another PR.

Signed-off-by: Harold Wang <harowang@amazon.com>
Signed-off-by: Harold Wang <harowang@amazon.com>
@harold-wang harold-wang merged commit fb13600 into opensearch-project:rename/opensearch Mar 4, 2021
nknize pushed a commit that referenced this pull request Mar 22, 2021
* [Rename] Rename qa folder

Signed-off-by: Harold Wang <harowang@amazon.com>

* Remove the dot in the end of "package org.opensearch."

Signed-off-by: Harold Wang <harowang@amazon.com>

* Add semicolon

Signed-off-by: Harold Wang <harowang@amazon.com>
ritty27 pushed a commit to ritty27/OpenSearch that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants