-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Rename files under "qa" folder #194
[Rename] Rename files under "qa" folder #194
Conversation
Signed-off-by: Harold Wang <harowang@amazon.com>
Request for Admin to accept this test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments but otherwise LGTM.
qa/die-with-dignity/src/main/java/org/elasticsearch/DieWithDignityPlugin.java
Outdated
Show resolved
Hide resolved
qa/die-with-dignity/src/main/java/org/elasticsearch/RestDieWithDignityAction.java
Outdated
Show resolved
Hide resolved
@@ -36,7 +36,7 @@ | |||
private static final String OS_NAME = System.getProperty("os.name"); | |||
private static final boolean WINDOWS = OS_NAME.startsWith("Windows"); | |||
|
|||
// These match the values defined in org.elasticsearch.gradle.testclusters.ElasticsearchNode | |||
// These match the values defined in org.opensearch.gradle.testclusters.OpensearchNode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'S' in OpenSearch should be capital OpenSearchNode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nknize it was ElasticsearchNode, I think we should use "OpensearchNode" instead of "OpenSearchNode". I will merge, will keep a note to check if I see "org.elasticsearch.gradle.testclusters.OpenSearchNode" after all renaming is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -17,47 +17,47 @@ | |||
* under the License. | |||
*/ | |||
|
|||
package org.elasticsearch.search; | |||
package org.opensearch.search; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file directory doesn't match with package name, please rename those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put all the git mv to different PR. thanks
@@ -16,7 +16,7 @@ | |||
* specific language governing permissions and limitations | |||
* under the License. | |||
*/ | |||
package org.elasticsearch.common.logging; | |||
package org.opensearch.common.logging; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name doesn't match with package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put all the git mv to different PR. thanks as I mentioned #194 (comment)
@@ -17,34 +17,34 @@ | |||
* under the License. | |||
*/ | |||
|
|||
package org.elasticsearch.upgrades; | |||
package org.opensearch.upgrades; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name doesn't match with package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put all the git mv to different PR. thanks as I mentioned in #194 (comment)
@@ -17,10 +17,10 @@ | |||
* under the License. | |||
*/ | |||
|
|||
package org.elasticsearch.bootstrap; | |||
package org.opensearch.bootstrap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- file directory doesn't match with package name.
- file name needs to be changed to
OpenSearchPolicyUnitTests.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put all the git mv to different PR as I mentioned #194 (comment)
@@ -17,13 +17,13 @@ | |||
* under the License. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file name needs to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put all the git mv to different PR as I mentioned in #194 (comment)
@@ -16,11 +16,11 @@ | |||
* specific language governing permissions and limitations | |||
* under the License. | |||
*/ | |||
package org.elasticsearch.upgrades; | |||
package org.opensearch.upgrades; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name doesn't match with package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file or dir rename is taken care of in another PR.
@@ -17,46 +17,46 @@ | |||
* under the License. | |||
*/ | |||
|
|||
package org.elasticsearch.http; | |||
package org.opensearch.http; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name doesn't match with package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file or dir rename is taken care of in another PR.
@@ -17,11 +17,11 @@ | |||
* under the License. | |||
*/ | |||
|
|||
package org.elasticsearch.smoketest; | |||
package org.opensearch.smoketest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name doesn't match with package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file or dir rename is taken care of in another PR.
@@ -17,13 +17,13 @@ | |||
* under the License. | |||
*/ | |||
|
|||
package org.elasticsearch.smoketest; | |||
package org.opensearch.smoketest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name doesn't match with package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file or dir rename is taken care of in another PR.
import org.elasticsearch.script.TemplateScript; | ||
import org.elasticsearch.script.mustache.MustacheScriptEngine; | ||
import org.elasticsearch.test.ESTestCase; | ||
package org.opensearch.ingest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directory name doesn't match with package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file or dir rename is taken care of in another PR.
Signed-off-by: Harold Wang <harowang@amazon.com>
Signed-off-by: Harold Wang <harowang@amazon.com>
* [Rename] Rename qa folder Signed-off-by: Harold Wang <harowang@amazon.com> * Remove the dot in the end of "package org.opensearch." Signed-off-by: Harold Wang <harowang@amazon.com> * Add semicolon Signed-off-by: Harold Wang <harowang@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Issue #160, if available:
Description of changes:
Rename files under "qa" folder:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.