Fix race condition in IndexServiceTests #19281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrross
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>test-failure
reta
reviewed
Sep 12, 2025
server/src/test/java/org/opensearch/index/IndexServiceTests.java
Outdated
Show resolved
Hide resolved
reta
approved these changes
Sep 12, 2025
|
❌ Gradle check result for 3443467: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
force-pushed
the
fix-indexservicetests-race
branch
from
3443467 to
076e30b
Compare
|
❌ Gradle check result for 076e30b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Sep 15, 2025
prudhvigodithi
approved these changes
Sep 15, 2025
|
❕ Gradle check result for 076e30b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19281 +/- ##
============================================
- Coverage 72.89% 72.77% -0.12%
+ Complexity 69763 69681 -82
============================================
Files 5667 5667
Lines 320547 320547
Branches 46348 46348
============================================
- Hits 233648 233279 -369
- Misses 68005 68353 +348
- Partials 18894 18915 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere. Signed-off-by: Andrew Ross <andrross@amazon.com>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
asimmahmood1
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 23, 2025
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere. Signed-off-by: Andrew Ross <andrross@amazon.com>
pranikum
pushed a commit
to pranikum/OpenSearch
that referenced
this pull request
Sep 23, 2025
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere. Signed-off-by: Andrew Ross <andrross@amazon.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere. Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test method had a race condition when getting an index after closing. This change extracts the common pattern of polling until the index is available and uses it everywhere.
Fixes #14407
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.