- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.3k
Bump netty from 4.1.124.Final to 4.1.125.Final #19269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump netty from 4.1.124.Final to 4.1.125.Final #19269
Conversation
Signed-off-by: Andrew Ross <andrross@amazon.com>
481bf24    to
    c6ff25c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI There is a Draft PR open for a bump to 4.2 here: #19178
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@             Coverage Diff              @@
##               main   #19269      +/-   ##
============================================
+ Coverage     72.78%   72.92%   +0.14%     
- Complexity    69651    69690      +39     
============================================
  Files          5658     5658              
  Lines        320114   320114              
  Branches      46350    46350              
============================================
+ Hits         233004   233459     +455     
+ Misses        68248    67714     -534     
- Partials      18862    18941      +79     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| The backport to  To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.19
# Create a new branch
git switch --create backport/backport-19269-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1df543e04d7605b7ee37587ff5c635609ebdafbd
# Push it to GitHub
git push --set-upstream origin backport/backport-19269-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.19Then, create a pull request where the  | 
* [2.19] Upgrade netty from 4.1.121.Final to 4.1.125.Final Signed-off-by: Craig Perkins <cwperx@amazon.com> * Bump netty from 4.1.124.Final to 4.1.125.Final (#19269) Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 1df543e) * remove unnecessary file Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update transport-nio build.gradle file as well Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
| Any chance this'll get backported to 3.2.0 branch? We're running into vulnerabilities in our scans, which get fixed with the 4.1.125 version of Netty. | 
…earch-project#19270) * [2.19] Upgrade netty from 4.1.121.Final to 4.1.125.Final Signed-off-by: Craig Perkins <cwperx@amazon.com> * Bump netty from 4.1.124.Final to 4.1.125.Final (opensearch-project#19269) Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 1df543e) * remove unnecessary file Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update transport-nio build.gradle file as well Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com> Co-authored-by: Andrew Ross <andrross@amazon.com>
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.