Skip to content

Conversation

@sandeshkr419
Copy link
Member

@sandeshkr419 sandeshkr419 commented Sep 2, 2025

Description

Introducing 2 new metrics in stats API to capture failure metrics:

  • search.query_failed
  • search.startree_query_failed

Related Issues

Resolves #19210

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

❌ Gradle check result for 304e6e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

❌ Gradle check result for f070620: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419 sandeshkr419 added v3.3.0 Search Search query, autocomplete ...etc labels Sep 14, 2025
@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Sep 14, 2025
@sandeshkr419 sandeshkr419 marked this pull request as ready for review September 14, 2025 20:20
@github-actions
Copy link
Contributor

❌ Gradle check result for 8d6bc05: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 7156637: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 7156637: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 72.54902% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.96%. Comparing base (47aa8ee) to head (b060a80).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../opensearch/rest/action/cat/RestIndicesAction.java 46.66% 0 Missing and 8 partials ⚠️
...org/opensearch/index/search/stats/SearchStats.java 90.90% 0 Missing and 2 partials ⚠️
...pensearch/index/search/stats/ShardSearchStats.java 66.66% 2 Missing ⚠️
...rg/opensearch/rest/action/cat/RestNodesAction.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19209      +/-   ##
============================================
+ Coverage     72.93%   72.96%   +0.02%     
+ Complexity    70101    70090      -11     
============================================
  Files          5687     5687              
  Lines        321637   321681      +44     
  Branches      46521    46530       +9     
============================================
+ Hits         234587   234699     +112     
+ Misses        68134    68028     -106     
- Partials      18916    18954      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for a917f50: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for a917f50: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for e548e18: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@github-actions
Copy link
Contributor

❕ Gradle check result for b060a80: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@bharath-techie bharath-techie merged commit c48544d into opensearch-project:main Sep 30, 2025
32 of 33 checks passed
@sandeshkr419 sandeshkr419 deleted the fail branch September 30, 2025 06:37
asimmahmood1 pushed a commit to asimmahmood1/OpenSearch that referenced this pull request Sep 30, 2025
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Search:Query Insights Search Search query, autocomplete ...etc v3.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] [Search] Query Failure Related Stats

4 participants