Respects the routing field in TermVectorsRequest in the REST client #19195
Conversation
github-actions
bot
added
bug
axiak
force-pushed
the
2.17-routing-patch
branch
2 times, most recently
from
3e17281 to
eb5ceb1
Compare
|
❌ Gradle check result for eb5ceb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The TermVectorsRequest object accepts a routing field to be set, but doesn't serialize this value out. This means that it does not actually get sent to the server, and is ignored. This change actually respects it, as well as adds a simple test to ensure that it gets sent. Signed-off-by: Michael Axiak <mike@axiak.net>
andrross
force-pushed
the
2.17-routing-patch
branch
from
eb5ceb1 to
50de671
Compare
Signed-off-by: Andrew Ross <andrross@amazon.com>
|
Thanks @axiak! I've rebased this PR and added a changelog entry. |
|
❌ Gradle check result for 1833df1: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1833df1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Michael Axiak <mike@axiak.net>
|
❌ Gradle check result for 9e1582f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 9e1582f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19195 +/- ##
============================================
+ Coverage 72.78% 72.89% +0.10%
- Complexity 69651 69689 +38
============================================
Files 5658 5658
Lines 320114 320115 +1
Branches 46350 46351 +1
============================================
+ Hits 233004 233346 +342
+ Misses 68248 67818 -430
- Partials 18862 18951 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR is stalled because it has been open for 30 days with no activity. |
2 participants
Description
The TermVectorsRequest object accepts a routing field to be set,
but doesn't serialize this value out. This means that it does not
actually get sent to the server, and is ignored.
This change actually respects it, as well as adds a simple test
to ensure that it gets sent.
Related Issues
Resolves #19194
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.