Skip to content

Fix LocalTranslogTests handling of corrupted translog recovery #19177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2025
Merged

Fix LocalTranslogTests handling of corrupted translog recovery #19177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce48ec
Fix LocalTranslogTests handling of corrupted translog recovery
atris Aug 28, 2025
9619631
Merge remote-tracking branch 'origin/main' into fix_tra
atris Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/src/test/java/org/opensearch/index/translog/LocalTranslogTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3368,8 +3368,8 @@ public void testWithRandomException() throws IOException {
localCheckpointOfSafeCommit = failableTLog.getDeletionPolicy().getLocalCheckpointOfSafeCommit();
IOUtils.closeWhileHandlingException(failableTLog);
}
} catch (TranslogException | MockDirectoryWrapper.FakeIOException ex) {
// failed - that's ok, we didn't even create it
} catch (TranslogException | MockDirectoryWrapper.FakeIOException | TranslogCorruptedException ex) {
// failed - that's ok, we didn't even create it or it was corrupted from partial writes
} catch (IOException ex) {
assertEquals(ex.getMessage(), "__FAKE__ no space left on device");
}
Expand All @@ -3379,8 +3379,8 @@ public void testWithRandomException() throws IOException {
TranslogDeletionPolicy deletionPolicy = createTranslogDeletionPolicy();
deletionPolicy.setLocalCheckpointOfSafeCommit(localCheckpointOfSafeCommit);
IOUtils.close(getFailableTranslog(fail, config, randomBoolean(), false, generationUUID, deletionPolicy));
} catch (TranslogException | MockDirectoryWrapper.FakeIOException ex) {
// failed - that's ok, we didn't even create it
} catch (TranslogException | MockDirectoryWrapper.FakeIOException | TranslogCorruptedException ex) {
// failed - that's ok, we didn't even create it or it was corrupted from partial writes
} catch (IOException ex) {
assertEquals(ex.getMessage(), "__FAKE__ no space left on device");
}
Expand Down
Loading