-
Couldn't load subscription status.
- Fork 2.3k
Fix access specifier for FieldMapper method to allow usage by plugins #19113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix access specifier for FieldMapper method to allow usage by plugins #19113
Conversation
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
|
Note: The issue only impacts when derived source is enabled on an index with scaled_float mapping type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19113 +/- ##
============================================
- Coverage 72.98% 72.81% -0.18%
+ Complexity 69475 69388 -87
============================================
Files 5647 5647
Lines 319210 319210
Branches 46171 46171
============================================
- Hits 232977 232420 -557
- Misses 67385 67986 +601
+ Partials 18848 18804 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9e64838
into
opensearch-project:main
…opensearch-project#19113) * Fix access specifier for FieldMapper method to allow usage by plugins Signed-off-by: Mohit Godwani <mgodwan@amazon.com> * Apply spotless Signed-off-by: Mohit Godwani <mgodwan@amazon.com> --------- Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
…opensearch-project#19113) * Fix access specifier for FieldMapper method to allow usage by plugins Signed-off-by: Mohit Godwani <mgodwan@amazon.com> * Apply spotless Signed-off-by: Mohit Godwani <mgodwan@amazon.com> --------- Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
…opensearch-project#19113) * Fix access specifier for FieldMapper method to allow usage by plugins Signed-off-by: Mohit Godwani <mgodwan@amazon.com> * Apply spotless Signed-off-by: Mohit Godwani <mgodwan@amazon.com> --------- Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
…opensearch-project#19113) * Fix access specifier for FieldMapper method to allow usage by plugins Signed-off-by: Mohit Godwani <mgodwan@amazon.com> * Apply spotless Signed-off-by: Mohit Godwani <mgodwan@amazon.com> --------- Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Description
When enabling scaled_float field, due to different ClassLoader being used for module, and core, ScaledFloatFieldMapper is unable to access package-protected methods. This is leading to process being killed due to the fatal error. This commit fixes the same.
Related Issues
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.