Raise error when unrecognized content token type is found while indexing #19097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for ac73676: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bruce-hong-glean
force-pushed
the
fix-false-allow-templates-edge-case
branch
from
ac73676 to
af8219f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19097 +/- ##
============================================
+ Coverage 72.79% 72.83% +0.03%
- Complexity 69605 69683 +78
============================================
Files 5658 5658
Lines 320079 320078 -1
Branches 46345 46345
============================================
+ Hits 232996 233114 +118
+ Misses 68230 68085 -145
- Partials 18853 18879 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bruce-hong-glean
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19 and
reta
as code owners
bruce-hong-glean
requested review from
a team,
VachaShah,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
gaobinlong
reviewed
Aug 19, 2025
gaobinlong
reviewed
Aug 19, 2025
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
…com/bruce-hong-glean/OpenSearch into fix-false-allow-templates-edge-case
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
|
❌ Gradle check result for f87c059: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bruce Hong <bruce.hong@glean.com>
|
^ wanted to bump this. Wasn't really sure what a good solution to the remaining comment was. cc @andrross as well since you helped merge the original PR |
andrross
approved these changes
Sep 4, 2025
|
❕ Gradle check result for 57d5304: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
This was referenced Sep 20, 2025
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…ing (opensearch-project#19097) Signed-off-by: Bruce Hong <bruce.hong@glean.com>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…ing (opensearch-project#19097) Signed-off-by: Bruce Hong <bruce.hong@glean.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…ing (opensearch-project#19097) Signed-off-by: Bruce Hong <bruce.hong@glean.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
asimmahmood1
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 23, 2025
…ing (opensearch-project#19097) Signed-off-by: Bruce Hong <bruce.hong@glean.com>
pranikum
pushed a commit
to pranikum/OpenSearch
that referenced
this pull request
Sep 23, 2025
…ing (opensearch-project#19097) Signed-off-by: Bruce Hong <bruce.hong@glean.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…ing (opensearch-project#19097) Signed-off-by: Bruce Hong <bruce.hong@glean.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We merged this PR last week to introduce
false_allow_templatesas an indexing option. Taking another pass after it was merged, I realized it changed some behaviour in other indexing cases too (where there in an unrecognized content token). This should probably throw an error regardless of indexing rules and this returns to status quo before the PR above.Related Issues
Not sure how strict this is. Let me know if I should create an issue for this.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.