fix flaky test PemTrustConfigTests#testTrustConfigReloadsFileContents #19057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 1606dff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
cwperks
approved these changes
Aug 13, 2025
This was referenced Aug 13, 2025
|
❌ Gradle check result for 1606dff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Aug 12, 2025
|
❌ Gradle check result for 76322ec: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
(opensearch-project#19057) Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
|
❌ Gradle check result for 41c1fb2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
…opensearch-project#19057) (opensearch-project#19057) Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
karenyrx
pushed a commit
to karenyrx/OpenSearch
that referenced
this pull request
Aug 21, 2025
…opensearch-project#19057) (opensearch-project#19057) Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
atris
pushed a commit
to atris/OpenSearch
that referenced
this pull request
Aug 28, 2025
…opensearch-project#19057) (opensearch-project#19057) Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
…opensearch-project#19057) (opensearch-project#19057) Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…opensearch-project#19057) (opensearch-project#19057) Signed-off-by: Igonin <iigonin@sternad.de> Co-authored-by: Igonin <iigonin@sternad.de> Co-authored-by: Benny Goerzig <benny.goerzig@sap.com> Co-authored-by: Karsten Schnitter <k.schnitter@sap.com> Co-authored-by: Kai Sternad <k.sternad@sternad.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is within
PemTrustConfigTests#generateRandomByteArrayOfLengthwhen random bytes accidentally start with
0x30(the ASN.1 SEQUENCE tag), the certificate parser do attempt to parse them as DER-encoded ASN.1 data, leading to a different error message ("cannot create trust using PEM certificates") compared to when the bytes clearly aren't certificate-like ("Failed to parse any certificate from"). This cause test flakiness because the same test would sometimes pass with one expected error message and sometimes fail when the random data triggers the other parsing path.Related Issues
Resolves #17983
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.