Pressure service for merged segment warmer #19009
Conversation
|
❌ Gradle check result for 2a150a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ba35271: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 73e3241: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for bf9ae91: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| translog = in.readOptionalWriteable(TranslogStats::new); | ||
| requestCache = in.readOptionalWriteable(RequestCacheStats::new); | ||
| recoveryStats = in.readOptionalWriteable(RecoveryStats::new); | ||
| mergedSegmentWarmerStats = in.readOptionalWriteable(MergedSegmentWarmerStats::new); |
There was a problem hiding this comment.
Add version checks here. Like this: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/action/admin/indices/stats/ShardStats.java#L168-L170
The payload sent from the data node running lower version would not have this field, without version check based ser-de, the stats API would break during version upgrades
Signed-off-by: kh3ra <adityakh3ra@gmail.com> Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: kh3ra <adityakh3ra@gmail.com> Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: kh3ra <adityakh3ra@gmail.com> Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
Signed-off-by: kh3ra <adityakh3ra@gmail.com>
Signed-off-by: kh3ra <adityakh3ra@gmail.com>
Signed-off-by: kh3ra <adityakh3ra@gmail.com>
Signed-off-by: kh3ra <adityakh3ra@gmail.com>
Signed-off-by: Aditya Khera <kheraadi@amazon.com>
kh3ra
force-pushed
the
dev/merged-segment-warmer-pressure-service
branch
from
bf9ae91 to
d422f60
Compare
|
❌ Gradle check result for d422f60: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
2 participants
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.