[Backport 3.2] Optimization in Numeric Terms Aggregation query for Large Bucket Counts #18974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts (#18702) * optimize num agg using quick select for topN when applicable Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 130d890) * Updated the numeric term aggregation logic to select topN Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Updated the algorithm selection logic Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added a feature flag for the implementation Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added profile debug information Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * use priority queue method for significant terms Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Refactored the selection strategy Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added tests case with proper assertions Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> * Added cluster settings for selection strategy Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> --------- Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com> Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com> Co-authored-by: Rishabh Maurya <rishabhmaurya05@gmail.com> (cherry picked from commit 7db7a5a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
23 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.2 #18974 +/- ##
============================================
- Coverage 72.90% 72.79% -0.12%
+ Complexity 69349 69314 -35
============================================
Files 5642 5643 +1
Lines 318636 318713 +77
Branches 46107 46112 +5
============================================
- Hits 232306 232011 -295
- Misses 67484 67936 +452
+ Partials 18846 18766 -80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rishabhmaurya
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7db7a5a from #18702.