Skip to content

Conversation

@karenyrx
Copy link
Contributor

@karenyrx karenyrx commented Aug 5, 2025

Description

Now that transport-grpc has been converted to a module rather than a plugin, remove all references of a 'plugin'.

  1. Rename the package from org.opensearch.plugin.transport.grpc to org.opensearch.transport.grpc
  2. Remove the plugin/ folder from all paths under modules/transport-grpc, e.g. move files from modules/transport-grpc/src/main/java/org/opensearch/plugin/transport/grpc to modules/transport-grpc/src/main/java/org/opensearch/transport/grpc
  3. Fix some minor comments still referencing 'plugin' as well.

Related Issues

Related to #18893

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@karenyrx karenyrx changed the title [GRPC] Rename package org.opensearch.plugin.transport.grpc to org.ope… [GRPC] Rename package org.opensearch.plugin.transport.grpc to org.opensearch.transport.grpc Aug 5, 2025
@karenyrx karenyrx marked this pull request as ready for review August 5, 2025 13:52
@karenyrx karenyrx requested a review from a team as a code owner August 5, 2025 13:52
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for cb5cf29: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…nsearch.transport.grpc

Signed-off-by: Karen Xu <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❕ Gradle check result for 8421a5d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.82%. Comparing base (9e49930) to head (8421a5d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18923      +/-   ##
============================================
+ Coverage     72.74%   72.82%   +0.08%     
- Complexity    68840    68867      +27     
============================================
  Files          5601     5601              
  Lines        316394   316394              
  Branches      45872    45872              
============================================
+ Hits         230155   230409     +254     
+ Misses        67599    67313     -286     
- Partials      18640    18672      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit c5f44b8 into opensearch-project:main Aug 5, 2025
37 checks passed
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
…nsearch.transport.grpc (opensearch-project#18923)

Signed-off-by: Karen Xu <karenxyr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants