Skip to content

Conversation

@bzhangam
Copy link
Contributor

@bzhangam bzhangam commented Aug 4, 2025

Description

Reset isPipelineResolved to false to resolve the system ingest pipeline again. If we don't reset it as false we simply skip resolving the pipeline.

Related Issues

Resolves #18909

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bzhangam bzhangam requested a review from a team as a code owner August 4, 2025 22:49
@github-actions github-actions bot added bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing labels Aug 4, 2025
@bzhangam bzhangam closed this Aug 4, 2025
@bzhangam bzhangam force-pushed the fixsystempipeline branch from fbde32d to 8d40807 Compare August 4, 2025 22:50
@bzhangam bzhangam reopened this Aug 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2025

❌ Gradle check result for eb1ee06: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bzhangam bzhangam force-pushed the fixsystempipeline branch from eb1ee06 to a779b1d Compare August 5, 2025 00:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for a779b1d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bzhangam bzhangam closed this Aug 5, 2025
@bzhangam bzhangam force-pushed the fixsystempipeline branch from a779b1d to 9e49930 Compare August 5, 2025 16:04
@bzhangam bzhangam reopened this Aug 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for 1f284ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@bzhangam bzhangam closed this Aug 5, 2025
@bzhangam bzhangam reopened this Aug 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

❌ Gradle check result for 1f284ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19
Copy link
Member

@bzhangam can you run ./gradlew :server:spotlessApply, spotless is failing precommit and other checks

…ne again.

Signed-off-by: Bo Zhang <bzhangam@amazon.com>
@bzhangam bzhangam force-pushed the fixsystempipeline branch from 1f284ad to 8119208 Compare August 5, 2025 16:51
@bzhangam
Copy link
Contributor Author

bzhangam commented Aug 5, 2025

@bzhangam can you run ./gradlew :server:spotlessApply, spotless is failing precommit and other checks

fixed

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @bzhangam

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

✅ Gradle check result for 8119208: SUCCESS

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.83%. Comparing base (9e49930) to head (8119208).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18911      +/-   ##
============================================
+ Coverage     72.74%   72.83%   +0.09%     
- Complexity    68840    68868      +28     
============================================
  Files          5601     5601              
  Lines        316394   316395       +1     
  Branches      45872    45872              
============================================
+ Hits         230155   230450     +295     
+ Misses        67599    67230     -369     
- Partials      18640    18715      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@owaiskazi19 owaiskazi19 merged commit f40ad67 into opensearch-project:main Aug 5, 2025
31 checks passed
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] System ingest pipeline not triggered when request is from a non-ingest node

2 participants