Move transport-grpc from a core plugin to a module #18897
Merged
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
karenyrx
changed the title
Signed-off-by: Karen Xu <karenxyr@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18897 +/- ##
============================================
- Coverage 72.93% 72.79% -0.14%
+ Complexity 68855 68822 -33
============================================
Files 5590 5590
Lines 315887 315887
Branches 45839 45839
============================================
- Hits 230382 229949 -433
- Misses 66832 67324 +492
+ Partials 18673 18614 -59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
finnegancarroll
approved these changes
Aug 2, 2025
This was referenced Aug 3, 2025
amberzsy
approved these changes
Aug 4, 2025
varunbharadwaj
approved these changes
Aug 4, 2025
yupeng9
approved these changes
Aug 4, 2025
Signed-off-by: Karen Xu <karenxyr@gmail.com>
|
❌ Gradle check result for ef14e31: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen Xu <karenxyr@gmail.com>
msfroh
approved these changes
Aug 4, 2025
|
❕ Gradle check result for d506f7b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sunqijun1
pushed a commit
to sunqijun1/OpenSearch
that referenced
this pull request
Aug 5, 2025
…t#18897) Signed-off-by: Karen Xu <karenxyr@gmail.com> Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>
sunqijun1
pushed a commit
to sunqijun1/OpenSearch
that referenced
this pull request
Aug 5, 2025
…t#18897) Signed-off-by: Karen Xu <karenxyr@gmail.com> Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>
sunqijun1
pushed a commit
to sunqijun1/OpenSearch
that referenced
this pull request
Aug 5, 2025
…t#18897) Signed-off-by: Karen Xu <karenxyr@gmail.com> Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>
6 tasks
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…t#18897) Signed-off-by: Karen Xu <karenxyr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As outlined in issue #18893, we propose to move the transport-grpc plugin to a module from a plugin.
This PR moves the code from the
/pluginsfolder to the/modulesfolder and updates the README on testing/running the module.Related Issues
Resolves #18893
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.