Skip to content

Created a new lib metadata-common and separated out AliasMetadata with required dependencies from the server #18844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Created a new lib metadata-common and separated out AliasMetadata with required dependencies from the server #18844

wants to merge 1 commit into from

Conversation

@gargmanik13
Copy link
Contributor

Created a new lib metadata-common and separated out AliasMetadata with required dependencies from the server

Description

  • Created a new library metadata-common under libs folder in the OpenSearch repo.
  • This will help to separate out the metadata related dependencies which are currently coupled with cluster management dependencies in the server package. It'll make the Cluster Manager more cloud native provider friendly and help to eventually run the CM in stateless mode.
  • As part of this change, moved AliasMetadata with required dependencies like - common, cluster.metadata etc.
  • Will follow-up with IndexMetadata and required dependencies in next PR.

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

✅ Gradle check result for 394b9a0: SUCCESS

@codecov
Copy link

codecov bot commented Jul 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.82%. Comparing base (40e9e40) to head (dd50bb8).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/common/logging/XOpaqueIdProvider.java 60.00% 1 Missing and 1 partial ⚠️
...action/admin/cluster/RestClusterRerouteAction.java 0.00% 1 Missing ⚠️
...t/action/admin/cluster/RestClusterStateAction.java 0.00% 1 Missing ⚠️
...ction/admin/cluster/RestGetRepositoriesAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #18844      +/-   ##
============================================
+ Coverage     72.80%   72.82%   +0.02%     
- Complexity    68609    68621      +12     
============================================
  Files          5572     5574       +2     
  Lines        315196   315205       +9     
  Branches      45750    45750              
============================================
+ Hits         229466   229545      +79     
+ Misses        67166    67110      -56     
+ Partials      18564    18550      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

❕ Gradle check result for dd50bb8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jul 24, 2025
Open
rajiv-kv
rajiv-kv reviewed Jul 28, 2025
View reviewed changes
@gargmanik13 gargmanik13 force-pushed the metadata-common branch 2 times, most recently from db8473d to 8c11cdc Compare July 29, 2025 12:14
@gargmanik13
Created a new lib metadata-common and separated out AliasMetadata wit…
d94e996 
…h required dependencies from the server

Signed-off-by: Manik Garg <gargmanik1317@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for d94e996: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Jul 29, 2025
Closed
Open
Open
@gargmanik13
Copy link
Contributor Author

❌ Gradle check result for d94e996: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test Result (1 failure / ±0)
org.opensearch.index.store.remote.utils.TransferManagerBlobContainerReaderTests.testOverflowDisabledAsynchronous

Flaky test: #18872

rajiv-kv
rajiv-kv reviewed Jul 31, 2025
View reviewed changes
server/src/main/java/org/opensearch/node/Node.java
resourcesToClose.add(() -> ThreadPool.terminate(threadPool, 10, TimeUnit.SECONDS));
final ResourceWatcherService resourceWatcherService = new ResourceWatcherService(settings, threadPool);
resourcesToClose.add(resourceWatcherService);
// adds the context to the DeprecationLogger so that it does not need to be injected everywhere
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we revert the comment ?

@gargmanik13 gargmanik13 deleted the metadata-common branch August 11, 2025 05:47
@gargmanik13 gargmanik13 mentioned this pull request Oct 11, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rajiv-kv rajiv-kv rajiv-kv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gargmanik13 @rajiv-kv