-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix variable reference errors causing incorrect log outputs in LocalhardsBalancer #18827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variable reference errors causing incorrect log outputs in LocalhardsBalancer #18827
Conversation
|
❌ Gradle check result for 20602c3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
20602c3 to
5cfafb1
Compare
|
❌ Gradle check result for 5cfafb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5cfafb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Thank you for the fix! |
|
❌ Gradle check result for 5cfafb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5cfafb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@sunqijun1 Can you rebase this PR with the the latest changes on main? |
|
❌ Gradle check result for 5cfafb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…hardsBalancer Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>
5cfafb1 to
31a9e57
Compare
|
❌ Gradle check result for 31a9e57: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18827 +/- ##
============================================
- Coverage 72.79% 72.75% -0.04%
+ Complexity 68627 68608 -19
============================================
Files 5572 5577 +5
Lines 315196 315375 +179
Branches 45750 45772 +22
============================================
+ Hits 229454 229466 +12
- Misses 67153 67261 +108
- Partials 18589 18648 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…hardsBalancer (opensearch-project#18827) Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com> Co-authored-by: sunqijun.jun <sunqijun.jun@bytedance.com> Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com>
…hardsBalancer (opensearch-project#18827) Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com> Co-authored-by: sunqijun.jun <sunqijun.jun@bytedance.com>
…hardsBalancer (opensearch-project#18827) Signed-off-by: sunqijun.jun <sunqijun.jun@bytedance.com> Co-authored-by: sunqijun.jun <sunqijun.jun@bytedance.com>
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.