Remove unwanted unreleased versions #1877
Conversation
Only last major (2.0.0), last minor(1.3.0) and (1.2.4) can be unreleased Signed-off-by: Rabi Panda <adnapibar@gmail.com>
adnapibar
added
bug
|
Can one of the admins verify this patch? |
| @@ -71,9 +71,7 @@ | |||
| public static final Version V_EMPTY = new Version(V_EMPTY_ID, org.apache.lucene.util.Version.LATEST); | |||
|
|
|||
| public static final Version V_1_0_0 = new Version(1000099, org.apache.lucene.util.Version.LUCENE_8_8_2); | |||
| public static final Version V_1_0_1 = new Version(1000199, org.apache.lucene.util.Version.LUCENE_8_8_2); | |||
There was a problem hiding this comment.
Opensearch 1.0.1 seems to be a valid release [1], no?
[1] https://artifacts.opensearch.org/releases/bundle/opensearch/1.0.1/opensearch-1.0.1-linux-x64.tar.gz
There was a problem hiding this comment.
@dblock should we bring it back? I could PR it shortly
There was a problem hiding this comment.
sorry about that, I'll add that back
I removed based on ./gradlew verifyVersions which will start failing once we add the version back.
And this is because we didn't release 1.0.1 to maven (https://repo1.maven.org/maven2/org/opensearch/opensearch/maven-metadata.xml) @dblock do you know if there was a reason why we didn't publish this version to maven?
There was a problem hiding this comment.
There were no changes in core for 1.0.1, see https://github.com/opensearch-project/opensearch-build/blob/main/release-notes/opensearch-release-notes-1.0.1.md, so there are no new maven artifacts. Maybe we did the right thing in removing it from here then?
There was a problem hiding this comment.
Oh right, I remember that, so we did distribution 1.0.1 (plugin changes?) but kept core to 1.0.0, it was very confusing indeed, @adnapibar @dblock I think we are fine here, the Opensearch server should never return 1.0.1 as its version.
There was a problem hiding this comment.
Yes I would think so, if there is no OpenSearch (core) 1.0.1 which is not in Maven then it doesn't make sense to include it as a released version. The reason we keep track of released versions is for backwards compatibility and 1.0.1 is same as 1.0.0.
Description
Latest release is
1.2.3Hence, only last major (
2.0.0), last minor(1.3.0) and (1.2.4) can be unreleasedIssues Resolved
Resolves #1855
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com