Skip to content

Bugfix arrow-flight-rpc plugin dependency injection collision #18483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

Bugfix arrow-flight-rpc plugin dependency injection collision #18483

merged 3 commits into from
Jun 11, 2025
+53 −14

Conversation

@finnegancarroll
Copy link
Contributor

@finnegancarroll finnegancarroll commented Jun 10, 2025 •
edited
Loading

Description

arrow-flight-rpc plugin provides the FlightService through both createComponent as well as getAuxTransports. These two instances collide when Node.java dependency injection framework binds them both to FlightService.class.

Removing the createComponent instance to resolve this conflict. createComponent does not respect aux transport enable settings or port range settings.

Error:

»  uncaught exception in thread [main]
»  org.opensearch.common.inject.CreationException: Guice creation errors:
»
»  1) A binding to org.opensearch.arrow.flight.bootstrap.FlightService was already configured at _unknown_.
»    at _unknown_
»
»  1 error
»       at <<<guice>>>
»       at org.opensearch.node.Node.<init>(Node.java:1591)
»       at org.opensearch.node.Node.<init>(Node.java:464)
»       at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:249)
...

Related Issues

No issue

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@finnegancarroll
Bugfix enable FlightStreamPlugin.
036dc3b 
FlightStreamPlugin returns FlightService as AuxTransport as well as
createComponents. Both references attempt to bind to
FlightService.class and throws an exception. Removing redundant
createComponents instance.

Signed-off-by: Finn Carroll <carrofin@amazon.com>
@finnegancarroll
Update tests - Arrow flight transport now enabled through aux transpo…
aae030c 
…rt type.

Signed-off-by: Finn Carroll <carrofin@amazon.com>
@finnegancarroll
Add readme with enable commands.
b1c11ad 
Signed-off-by: Finn Carroll <carrofin@amazon.com>
@finnegancarroll finnegancarroll requested a review from a team as a code owner June 10, 2025 17:51
@finnegancarroll
Copy link
Contributor Author

@rishabhmaurya when convenient can you take a look at this small bugfix for flight service enable settings? Thanks!

@rishabhmaurya
Copy link
Contributor

@finnegancarroll thanks for taking care of it, looks good!

@github-actions
Copy link
Contributor

❌ Gradle check result for b1c11ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@finnegancarroll
Copy link
Contributor Author

Flaky test: #15840

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jun 10, 2025
Closed
@github-actions
Copy link
Contributor

❌ Gradle check result for b1c11ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rishabhmaurya
Copy link
Contributor

rishabhmaurya commented Jun 10, 2025 •
edited
Loading

another flaky test, created #18485

@github-actions
Copy link
Contributor

❌ Gradle check result for b1c11ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for b1c11ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for b1c11ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for b1c11ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Jun 11, 2025
Open
Open
Open
@github-actions
Copy link
Contributor

❌ Gradle check result for b1c11ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for b1c11ad: SUCCESS

@codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.73%. Comparing base (cf13a80) to head (b1c11ad).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #18483      +/-   ##
============================================
+ Coverage     72.70%   72.73%   +0.03%     
- Complexity    68035    68087      +52     
============================================
  Files          5531     5531              
  Lines        313148   313148              
  Branches      45458    45458              
============================================
+ Hits         227670   227777     +107     
+ Misses        66944    66878      -66     
+ Partials      18534    18493      -41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rishabhmaurya rishabhmaurya merged commit 5255f5b into opensearch-project:main Jun 11, 2025
67 of 82 checks passed
This was referenced Jun 11, 2025
Closed
Open
abhita pushed a commit to abhita/OpenSearch that referenced this pull request Jun 17, 2025
@finnegancarroll @abhita
Bugfix arrow-flight-rpc plugin dependency injection collision (opense…
8313c95 
…arch-project#18483)

* Bugfix enable FlightStreamPlugin.

FlightStreamPlugin returns FlightService as AuxTransport as well as
createComponents. Both references attempt to bind to
FlightService.class and throws an exception. Removing redundant
createComponents instance.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Update tests - Arrow flight transport now enabled through aux transport type.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Add readme with enable commands.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

---------

Signed-off-by: Finn Carroll <carrofin@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
@finnegancarroll
Bugfix arrow-flight-rpc plugin dependency injection collision (opense…
41107e8 
…arch-project#18483)

* Bugfix enable FlightStreamPlugin.

FlightStreamPlugin returns FlightService as AuxTransport as well as
createComponents. Both references attempt to bind to
FlightService.class and throws an exception. Removing redundant
createComponents instance.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Update tests - Arrow flight transport now enabled through aux transport type.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Add readme with enable commands.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

---------

Signed-off-by: Finn Carroll <carrofin@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
@finnegancarroll @neuenfeldttj
Bugfix arrow-flight-rpc plugin dependency injection collision (opense…
f5038ba 
…arch-project#18483)

* Bugfix enable FlightStreamPlugin.

FlightStreamPlugin returns FlightService as AuxTransport as well as
createComponents. Both references attempt to bind to
FlightService.class and throws an exception. Removing redundant
createComponents instance.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Update tests - Arrow flight transport now enabled through aux transport type.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Add readme with enable commands.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

---------

Signed-off-by: Finn Carroll <carrofin@amazon.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
@finnegancarroll @tandonks
Bugfix arrow-flight-rpc plugin dependency injection collision (opense…
33dda92 
…arch-project#18483)

* Bugfix enable FlightStreamPlugin.

FlightStreamPlugin returns FlightService as AuxTransport as well as
createComponents. Both references attempt to bind to
FlightService.class and throws an exception. Removing redundant
createComponents instance.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Update tests - Arrow flight transport now enabled through aux transport type.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

* Add readme with enable commands.

Signed-off-by: Finn Carroll <carrofin@amazon.com>

---------

Signed-off-by: Finn Carroll <carrofin@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabhmaurya rishabhmaurya rishabhmaurya approved these changes

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@finnegancarroll @rishabhmaurya