-
Couldn't load subscription status.
- Fork 2.3k
fix indices.simulate_index_template test spec #18399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix indices.simulate_index_template test spec #18399
Conversation
Signed-off-by: saimedhi <saimedhi@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18399 +/- ##
============================================
+ Coverage 72.60% 72.70% +0.09%
- Complexity 67682 67776 +94
============================================
Files 5497 5497
Lines 311819 311819
Branches 45265 45265
============================================
+ Hits 226409 226702 +293
+ Misses 66941 66641 -300
- Partials 18469 18476 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@owaiskazi19 , @andrross , @dbwiddis please take a look at this PR. And let me know if any change needed. |
|
@saimedhi Can you explain why this change is required? |
@andrross, I am seeing a test failure in opensearch python client. Same issue observed in other clients as well. I debugged this issue and noticed response obtained after sequence of actions mentioned in test spec is {} So, asserting response body with {} should be done in test spec. Currently suggesting to change as below:
Previously :
|
|
@saimedhi But why does this not cause an issue in this repository if the spec is not correct? |
|
@saimedhi I'm going to merge this because I fully believe you that the actual response is |
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.