-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Made segment upload to remote async #18333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
❌ Gradle check result for d09228f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
I see 285 tests failure, can we fix them please? |
|
Lets ensure that we are rerunning the failing tests for around 1k iterations locally to confirm once we have fixed them. |
|
❌ Gradle check result for d09228f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for 73f116a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for 5c6edd1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for 15c0b0c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for f3c4ff5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for 4d4cb08: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for 1b24166: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for bdd0e36: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for 369e97a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kamal Nayan <askkamal@amazon.com>
|
❌ Gradle check result for 4424311: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
Description
This PR modifies the
runAfterRefreshWithPermitexecution to run asynchronously using the thread pool scheduler. This change will prevent blocking the refresh thread during segment uploads to remote storage. Primary nodes will become searchable just after the refresh completes without waiting for segments to get uploaded to the remote storage.Changes
runAfterRefreshWithPermitexecution to run asynchronously usingthreadPool.scheduleCheck List
Potential Risks
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.