Use QueryCoordinatorContext for the rewrite in validate API. #18272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzhangam
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❌ Gradle check result for 52be8dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bo Zhang <bzhangam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18272 +/- ##
============================================
+ Coverage 72.56% 72.58% +0.02%
- Complexity 67391 67437 +46
============================================
Files 5488 5488
Lines 311030 311062 +32
Branches 45216 45217 +1
============================================
+ Hits 225687 225786 +99
- Misses 66916 66921 +5
+ Partials 18427 18355 -72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saratvemulapalli
approved these changes
May 14, 2025
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Bo Zhang <bzhangam@amazon.com>
|
❌ Gradle check result for 812c1c5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 812c1c5: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
saratvemulapalli
merged commit ca3b005
into
opensearch-project:main
56 of 58 checks passed
This was referenced May 15, 2025
tanik98
pushed a commit
to tanik98/OpenSearch
that referenced
this pull request
May 27, 2025
…rch-project#18272) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
…rch-project#18272) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
neuenfeldttj
added a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…rch-project#18272) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…rch-project#18272) Signed-off-by: Bo Zhang <bzhangam@amazon.com> Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use QueryCoordinatorContext for the rewrite in validate API. We recently introduced QueryCoordinatorContext for the query rewrite on the coordinate level. In validate API we need to do rewrite on the coordinate level so we should use QueryCoordinatorContext. It's also required to support a new feature semantic field in the neural plugin.
Related Issues
It's needed to support a new feature semantic field in the neural plugin. Without this change a valid neural query against the semantic field will be viewed as invalid in the validate query API.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.