Skip to content

Fix flaky pull-based ingestion tests #18216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Fix flaky pull-based ingestion tests #18216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...on-kafka/src/internalClusterTest/java/org/opensearch/plugin/kafka/RemoteStoreKafkaIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,9 @@ public void testPauseAndResumeIngestion() throws Exception {
assertTrue(pauseResponse.isShardsAcknowledged());
waitForState(() -> {
GetIngestionStateResponse ingestionState = getIngestionState(indexName);
return Arrays.stream(ingestionState.getShardStates())
.allMatch(state -> state.isPollerPaused() && state.pollerState().equalsIgnoreCase("paused"));
return ingestionState.getFailedShards() == 0
&& Arrays.stream(ingestionState.getShardStates())
.allMatch(state -> state.isPollerPaused() && state.pollerState().equalsIgnoreCase("paused"));
});

// verify ingestion state is persisted
Expand Down
2 changes: 1 addition & 1 deletion plugins/ingestion-kafka/src/test/java/org/opensearch/plugin/kafka/KafkaUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public static void createTopic(String topicName, int numOfPartitions, String boo
}

// validates topic is created
await().atMost(10, TimeUnit.SECONDS).until(() -> checkTopicExistence(topicName, bootstrapServers));
await().atMost(60, TimeUnit.SECONDS).until(() -> checkTopicExistence(topicName, bootstrapServers));
}

public static boolean checkTopicExistence(String topicName, String bootstrapServers) {
Expand Down
Loading