-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Lower down the log level to DEBUG #18173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It would be great if we can back-port to 2.x as well. |
This logging message is relevant to experimental feature that is not yet turned on by default. When this code runs in production then this logging message is confisung OPS because there is nothing they can do to address this WARN level message. Closes: opensearch-project#18137 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
|
❕ Gradle check result for ff20d62: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18173 +/- ##
============================================
- Coverage 72.58% 72.42% -0.16%
+ Complexity 67219 67192 -27
============================================
Files 5476 5476
Lines 310445 310445
Branches 45121 45121
============================================
- Hits 225324 224850 -474
- Misses 66780 67265 +485
+ Partials 18341 18330 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@lukas-vlcek #18139 was merged yesterday which enabled this feature by default. Does it still make sense to change the log level here? We can make this change in the |
|
@andrross That is a great news! IMO it would be nice to merge it in 2.19 branch so that next maintenance release has it, but if that is a big hassle then we can just close this PR as "won't fix". |
@lukas-vlcek It's not a big hassle at all! Just open a PR directly against the |
Description
This logging message is relevant to experimental feature that is not yet turned on by default. When this code runs in production then this logging message is confisung OPS because there is nothing they can do to address this
WARNlevel message.Related Issues
Resolves: #18137
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.