Skip to content

Conversation

@lukas-vlcek
Copy link
Contributor

Description

This logging message is relevant to experimental feature that is not yet turned on by default. When this code runs in production then this logging message is confisung OPS because there is nothing they can do to address this WARN level message.

Related Issues

Resolves: #18137

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lukas-vlcek lukas-vlcek requested a review from a team as a code owner May 1, 2025 10:37
@github-actions github-actions bot added bug Something isn't working Cluster Manager labels May 1, 2025
@lukas-vlcek
Copy link
Contributor Author

It would be great if we can back-port to 2.x as well.

This logging message is relevant to experimental feature that is not
yet turned on by default. When this code runs in production then this
logging message is confisung OPS because there is nothing they can do
to address this WARN level message.

Closes: opensearch-project#18137

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2025

❕ Gradle check result for ff20d62: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (00abaac) to head (ff20d62).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18173      +/-   ##
============================================
- Coverage     72.58%   72.42%   -0.16%     
+ Complexity    67219    67192      -27     
============================================
  Files          5476     5476              
  Lines        310445   310445              
  Branches      45121    45121              
============================================
- Hits         225324   224850     -474     
- Misses        66780    67265     +485     
+ Partials      18341    18330      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross
Copy link
Member

andrross commented May 1, 2025

@lukas-vlcek #18139 was merged yesterday which enabled this feature by default. Does it still make sense to change the log level here?

We can make this change in the 2.19 branch so the log level will be fixed in the next 2.19.x release, but I'm not sure if we need to make the change here now that async batch is the default.

@lukas-vlcek
Copy link
Contributor Author

@andrross That is a great news!

IMO it would be nice to merge it in 2.19 branch so that next maintenance release has it, but if that is a big hassle then we can just close this PR as "won't fix".

@andrross
Copy link
Member

andrross commented May 1, 2025

if that is a big hassle

@lukas-vlcek It's not a big hassle at all! Just open a PR directly against the 2.19 branch to change the log level. This PR can probably be closed though.

@lukas-vlcek
Copy link
Contributor Author

@andrross Agree, closing in favor of #18186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Cluster Manager

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[BUG] Lower the log level from WARN to DEBUG for experimental feature: "batch allocation of unassigned shards"

2 participants