Skip to content

[Backport 3.0] Fix flaky simple test it #18075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[Backport 3.0] Fix flaky simple test it #18075

merged 1 commit into from
Apr 28, 2025

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 8948c1f from #18018.

@github-actions
Disable approximation when there is terminate after (#18018)
a204d82 
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit 8948c1f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for a204d82: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for a204d82: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Apr 25, 2025
Open
Open
@harshavamsi harshavamsi mentioned this pull request Apr 28, 2025
Closed
@github-actions
Copy link
Contributor

✅ Gradle check result for a204d82: SUCCESS

@codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.58%. Comparing base (aa27d70) to head (a204d82).
Report is 9 commits behind head on 3.0.

Files with missing lines Patch % Lines
...search/approximate/ApproximatePointRangeQuery.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.0   #18075      +/-   ##
============================================
+ Coverage     72.51%   72.58%   +0.07%     
- Complexity    67089    67128      +39     
============================================
  Files          5478     5478              
  Lines        310036   310038       +2     
  Branches      45072    45074       +2     
============================================
+ Hits         224809   225031     +222     
+ Misses        66892    66631     -261     
- Partials      18335    18376      +41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit bb0dff0 into 3.0 Apr 28, 2025
54 of 56 checks passed
@github-actions github-actions bot deleted the backport/backport-18018-to-3.0 branch April 28, 2025 20:02
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 29, 2025
Open
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
@opensearch-trigger-bot @github-actions @prudhvigodithi
Disable approximation when there is terminate after (opensearch-proje…
fe386de 
…ct#18018) (opensearch-project#18075)

(cherry picked from commit 8948c1f)

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prudhvigodithi prudhvigodithi prudhvigodithi approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prudhvigodithi @andrross @harshavamsi