Skip to content

Conversation

@yupeng9
Copy link
Contributor

@yupeng9 yupeng9 commented Apr 14, 2025

Description

  • add metric of skipped messages in pull-based ingestion processing
  • use record class for the PollingIngestStats

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yupeng Fu <yupeng@uber.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 69c8590: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 69c8590: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@yupeng9 yupeng9 closed this Apr 15, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 5a4da4c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@yupeng9 yupeng9 closed this Apr 15, 2025
@yupeng9 yupeng9 reopened this Apr 15, 2025
@github-actions
Copy link
Contributor

❌ Gradle check result for 5a4da4c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 5a4da4c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 5a4da4c: SUCCESS

@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (471acef) to head (85d7518).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ndices/pollingingest/MessageProcessorRunnable.java 70.00% 3 Missing ⚠️
...rch/indices/pollingingest/DefaultStreamPoller.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17938      +/-   ##
============================================
- Coverage     72.52%   72.49%   -0.04%     
+ Complexity    67031    66992      -39     
============================================
  Files          5470     5470              
  Lines        309707   309702       -5     
  Branches      45052    45046       -6     
============================================
- Hits         224617   224519      -98     
- Misses        66774    66822      +48     
- Partials      18316    18361      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Yupeng Fu <yupeng@uber.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 85d7518: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 85d7518: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 85d7518: SUCCESS

@mch2 mch2 merged commit cbaddd3 into opensearch-project:main Apr 16, 2025
31 checks passed
Lindsay-00 pushed a commit to Lindsay-00/OpenSearch that referenced this pull request Apr 22, 2025
…ensearch-project#17938)

* add metric of skipped messages in pull-based ingestion processing

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* fix plugin

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
Lindsay-00 pushed a commit to Lindsay-00/OpenSearch that referenced this pull request Apr 22, 2025
…ensearch-project#17938)

* add metric of skipped messages in pull-based ingestion processing

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* fix plugin

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Lingxi Chen <lingxich@amazon.com>
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
…ensearch-project#17938)

* add metric of skipped messages in pull-based ingestion processing

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* fix plugin

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ensearch-project#17938)

* add metric of skipped messages in pull-based ingestion processing

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* fix plugin

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ensearch-project#17938)

* add metric of skipped messages in pull-based ingestion processing

Signed-off-by: Yupeng Fu <yupeng@uber.com>

* fix plugin

Signed-off-by: Yupeng Fu <yupeng@uber.com>

---------

Signed-off-by: Yupeng Fu <yupeng@uber.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants