-
Notifications
You must be signed in to change notification settings - Fork 2.3k
add metric of skipped messages in pull-based ingestion processing #17938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yupeng Fu <yupeng@uber.com>
|
❌ Gradle check result for 69c8590: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 69c8590: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5a4da4c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5a4da4c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5a4da4c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17938 +/- ##
============================================
- Coverage 72.52% 72.49% -0.04%
+ Complexity 67031 66992 -39
============================================
Files 5470 5470
Lines 309707 309702 -5
Branches 45052 45046 -6
============================================
- Hits 224617 224519 -98
- Misses 66774 66822 +48
- Partials 18316 18361 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Yupeng Fu <yupeng@uber.com>
|
❌ Gradle check result for 85d7518: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 85d7518: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ensearch-project#17938) * add metric of skipped messages in pull-based ingestion processing Signed-off-by: Yupeng Fu <yupeng@uber.com> * fix plugin Signed-off-by: Yupeng Fu <yupeng@uber.com> --------- Signed-off-by: Yupeng Fu <yupeng@uber.com> Signed-off-by: Lingxi Chen <lingxich@amazon.com>
…ensearch-project#17938) * add metric of skipped messages in pull-based ingestion processing Signed-off-by: Yupeng Fu <yupeng@uber.com> * fix plugin Signed-off-by: Yupeng Fu <yupeng@uber.com> --------- Signed-off-by: Yupeng Fu <yupeng@uber.com> Signed-off-by: Lingxi Chen <lingxich@amazon.com>
…ensearch-project#17938) * add metric of skipped messages in pull-based ingestion processing Signed-off-by: Yupeng Fu <yupeng@uber.com> * fix plugin Signed-off-by: Yupeng Fu <yupeng@uber.com> --------- Signed-off-by: Yupeng Fu <yupeng@uber.com> Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
…ensearch-project#17938) * add metric of skipped messages in pull-based ingestion processing Signed-off-by: Yupeng Fu <yupeng@uber.com> * fix plugin Signed-off-by: Yupeng Fu <yupeng@uber.com> --------- Signed-off-by: Yupeng Fu <yupeng@uber.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ensearch-project#17938) * add metric of skipped messages in pull-based ingestion processing Signed-off-by: Yupeng Fu <yupeng@uber.com> * fix plugin Signed-off-by: Yupeng Fu <yupeng@uber.com> --------- Signed-off-by: Yupeng Fu <yupeng@uber.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.