Skip to content

Fix remove skip tags for version 7.x #17919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2025
Merged

Fix remove skip tags for version 7.x #17919

merged 4 commits into from
Apr 16, 2025

Conversation

@rgsriram
Copy link
Contributor

Description

Cleaning up skip tags for the test cases related to version 7.0.x to 7.10

Related Issues

#16574

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 8068dae: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 27ccc9c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 75af3a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for aa7e1d6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross
andrross reviewed Apr 14, 2025
View reviewed changes
@andrross
Copy link
Member

Thanks @rgsriram! Please take a look at the DCO workflow failure. You'll need to properly sign all commits.

This was referenced Apr 14, 2025
Open
Open
@rgsriram rgsriram force-pushed the fix-remove-skip-tags-for-version-7.x branch 2 times, most recently from 43a8348 to 8ea2ab2 Compare April 15, 2025 05:30
@rgsriram rgsriram requested a review from peternied as a code owner April 15, 2025 05:30
@rgsriram rgsriram force-pushed the fix-remove-skip-tags-for-version-7.x branch from 8ea2ab2 to 80a0bce Compare April 15, 2025 05:36
Sriram Ganesh added 4 commits April 15, 2025 11:07
@rgsriram
first commit
fddf9f8 
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
@rgsriram
Removed the skip tags for version 7.0 to 7.10.0
885365b 
Signed-off-by: Sriram Ganesh <sriram_ganesh@apple.com>
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
@rgsriram
Fixing the test case - node_info role test - before 2.0.0
a1580cf 
Signed-off-by: Sriram Ganesh <sriram_ganesh@apple.com>
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
@rgsriram
Fixing the test case added reason - node_info role test - before 2.0.0
1ad7167 
Signed-off-by: Sriram Ganesh <sriram_ganesh@apple.com>
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
@rgsriram rgsriram force-pushed the fix-remove-skip-tags-for-version-7.x branch from 80a0bce to 1ad7167 Compare April 15, 2025 05:37
@github-actions
Copy link
Contributor

✅ Gradle check result for 1ad7167: SUCCESS

@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.34%. Comparing base (5799fe7) to head (1ad7167).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17919      +/-   ##
============================================
- Coverage     72.57%   72.34%   -0.24%     
+ Complexity    67066    66898     -168     
============================================
  Files          5470     5470              
  Lines        309697   309770      +73     
  Branches      45045    45056      +11     
============================================
- Hits         224776   224095     -681     
- Misses        66602    67303     +701     
- Partials      18319    18372      +53

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rgsriram
Copy link
Contributor Author

Thanks @rgsriram! Please take a look at the DCO workflow failure. You'll need to properly sign all commits.

Done. Please kindly check it out.

@msfroh msfroh merged commit 8dbf800 into opensearch-project:main Apr 16, 2025
31 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 17, 2025
Open
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
@rgsriram @tqranjan
Remove skip tags for version 7.x from yamlRestTests (opensearch-proje…
6cd4d9a 
…ct#17919)

---------

Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
Signed-off-by: Sriram Ganesh <sriram_ganesh@apple.com>
Co-authored-by: Sriram Ganesh <sriram_ganesh@apple.com>
Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Apr 25, 2025
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request May 7, 2025
Open
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
@rgsriram
Remove skip tags for version 7.x from yamlRestTests (opensearch-proje…
e8c45f9 
…ct#17919)

---------

Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
Signed-off-by: Sriram Ganesh <sriram_ganesh@apple.com>
Co-authored-by: Sriram Ganesh <sriram_ganesh@apple.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
@rgsriram
Remove skip tags for version 7.x from yamlRestTests (opensearch-proje…
2e1faf5 
…ct#17919)

---------

Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
Signed-off-by: Sriram Ganesh <sriram_ganesh@apple.com>
Co-authored-by: Sriram Ganesh <sriram_ganesh@apple.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
@msfroh msfroh mentioned this pull request Sep 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrross andrross andrross left review comments

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr

@cwperks cwperks Awaiting requested review from cwperks

@jainankitk jainankitk Awaiting requested review from jainankitk

@linuxpi linuxpi Awaiting requested review from linuxpi

@peternied peternied Awaiting requested review from peternied

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rgsriram @andrross @msfroh