FIX BytesRefsCollectionBuilderTests.testBuildSortedNotSorted; Followup for #17714: Remove redundant tests

[mkhludnev]

I wasn't clear in communication under #17714. Let's sweep these tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[jainankitk]

I was hoping to keep the test code, if we ever need to run locally. But, I guess we can clean!

[github-actions]

❌ Gradle check result for dc44995: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mkhludnev]

looking into the failure

[github-actions]

❌ Gradle check result for 584643a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mkhludnev]

I think these failures are flaky. @jainankitk please consider for merging.

[github-actions]

❌ Gradle check result for 584643a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[harshavamsi]

@jainankitk can we re-run gradle check? This failure is showing up in other PRs and should get merged

[jainankitk]

@jainankitk can we re-run gradle check? This failure is showing up in other PRs and should get merged

Yes, retried the gradle check!

[github-actions]

❌ Gradle check result for 584643a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[mkhludnev]

https://build.ci.opensearch.org/job/gradle-check/56208/ seems unrelated

[jainankitk]

Retrying gradle check as caused due to unrelated failure

[github-actions]

❌ Gradle check result for 584643a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jainankitk]

Still unrelated failures, retrying gradle check:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/56225/testReport/) (3 failures / +3)

    [org.opensearch.rest.ReactorNetty4StreamingStressIT.testCloseClientStreamingRequest](https://build.ci.opensearch.org/job/gradle-check/56225/testReport/junit/org.opensearch.rest/ReactorNetty4StreamingStressIT/testCloseClientStreamingRequest/)
    [org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode](https://build.ci.opensearch.org/job/gradle-check/56225/testReport/junit/org.opensearch.snapshots/DedicatedClusterSnapshotRestoreIT/testSnapshotWithStuckNode/)

[github-actions]

❌ Gradle check result for 584643a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jainankitk]

We have too many flaky tests, another run failed due to unrelated test:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/56230/testReport/) (1 failure / ±0)

    [org.opensearch.indices.replication.SegmentReplicationResizeRequestIT.testCreateShrinkIndexThrowsExceptionWhenReplicasBehind](https://build.ci.opensearch.org/job/gradle-check/56230/testReport/junit/org.opensearch.indices.replication/SegmentReplicationResizeRequestIT/testCreateShrinkIndexThrowsExceptionWhenReplicasBehind/)

[github-actions]

✅ Gradle check result for 584643a: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (1628152) to head (584643a).
Report is 20 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17902      +/-   ##
============================================
+ Coverage     72.43%   72.51%   +0.07%     
- Complexity    66789    66837      +48     
============================================
  Files          5449     5452       +3     
  Lines        309085   309210     +125     
  Branches      44979    44991      +12     
============================================
+ Hits         223899   224226     +327     
+ Misses        66906    66556     -350     
- Partials      18280    18428     +148     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.