-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Star Tree] [Search] Support of Date Range Queries in Aggregations #17855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Gradle check result for e78f85a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17855 +/- ##
============================================
- Coverage 72.73% 72.67% -0.06%
- Complexity 67933 67960 +27
============================================
Files 5525 5527 +2
Lines 312697 312824 +127
Branches 45379 45406 +27
============================================
- Hits 227449 227360 -89
- Misses 66723 66911 +188
- Partials 18525 18553 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Gradle check result for 46e5cbb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Thanks @expani for this suggestion, makes the code much cleaner and abstracted. I also have a follow-up change #18477 planned to refactor StarTreeFilter next, that should help cleaning up some of the utility methods further by better supplying information about sub-dimension name. So, some of the utility methods where I'm hacking my way to get the sub-dimension from the first DimensionFilter within a list of DimensionFilters should clean-up naturally. These planned changes were spilling over the scope of this PR given this PR already huge because of the added support with boolean queries on date ranges. I would have ideally included the entire boolean query side of changes in a separate PR, but that would have left the support for boolean queries in a broken state. Alternatively, pre-refactoring this leaves the code in an ugly state for sure. |
|
Thanks @sandeshkr419 for the quick iteration on the comments. Looks very close to what I was thinking and using the intended design. Follow up PR sounds good as this PR is already too big. |
server/src/main/java/org/opensearch/search/startree/filter/provider/StarDateFieldMapper.java
Show resolved
Hide resolved
|
❌ Gradle check result for 80482d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 90b092c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/search/startree/filter/DimensionFilter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can take up the comments around design post this PR.
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
|
❕ Gradle check result for 0c9ce37: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
Helping with the merge as PR is already approved by multiple folks |
…pensearch-project#17855) * support for date range boolean queries Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
…pensearch-project#17855) * support for date range boolean queries Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
…pensearch-project#17855) * support for date range boolean queries Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
…pensearch-project#17855) * support for date range boolean queries Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Description
In existing aggregations supported by star-tree, this PR adds support for date range query to be used with supported aggregations. The query will be converted to a DimensionFilter and will be handled as part of star-tree traversal logic.
Related Issues
Resolves #17443
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.