Add the support of trusted file systems to AgentPolicy #17852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❌ Gradle check result for 8bdcb17: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3 tasks
Signed-off-by: Andriy Redko <drreta@gmail.com>
reta
commented
Apr 8, 2025
libs/agent-sm/agent/src/main/java/org/opensearch/javaagent/FileInterceptor.java
Show resolved
Hide resolved
andrross
approved these changes
Apr 9, 2025
|
❕ Gradle check result for 818a492: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17852 +/- ##
============================================
- Coverage 72.47% 72.42% -0.05%
+ Complexity 66534 66476 -58
============================================
Files 5408 5408
Lines 308217 308225 +8
Branches 44749 44751 +2
============================================
- Hits 223369 223228 -141
- Misses 66591 66741 +150
+ Partials 18257 18256 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…oject#17852) Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87
pushed a commit
to Harsh-87/OpenSearch
that referenced
this pull request
May 7, 2025
…oject#17852) Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the support of trusted file systems to AgentPolicy. The security checks where part of the
FileSystemimplementations (JDK) but we do use mock file systems (like Jimfs) in tests. Since we made checks global now, adding the support of trusted file systems (similarly to trusted hosts) to theAgentPolicyRelated Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.